Skip to content

Populate cargo env vars for crate_universe targets #3260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

illicitonion
Copy link
Collaborator

@illicitonion illicitonion commented Feb 12, 2025

Fixes #2677
Fixes #3250

@illicitonion illicitonion force-pushed the cargo-toml-vars-crate_universe branch from d9754f2 to 05b3788 Compare February 12, 2025 00:44
@illicitonion illicitonion force-pushed the cargo-toml-vars-crate_universe branch 2 times, most recently from 3de0f70 to 157b331 Compare March 10, 2025 22:41
@illicitonion illicitonion requested a review from UebelAndre March 10, 2025 22:43
@illicitonion illicitonion marked this pull request as ready for review March 10, 2025 22:43
@illicitonion illicitonion enabled auto-merge March 10, 2025 22:43
Copy link
Collaborator

@UebelAndre UebelAndre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you wanna regenerate files within the repo with this change? It would be nice to see a diff of the before and after for BUILD files generated.

@illicitonion illicitonion disabled auto-merge March 10, 2025 22:46
@illicitonion illicitonion force-pushed the cargo-toml-vars-crate_universe branch from 157b331 to 32ff7ab Compare March 11, 2025 00:11
@illicitonion illicitonion mentioned this pull request Mar 11, 2025
@illicitonion illicitonion added this pull request to the merge queue Mar 11, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 11, 2025
@illicitonion illicitonion added this pull request to the merge queue Mar 11, 2025
Merged via the queue into bazelbuild:main with commit 8a5afe1 Mar 11, 2025
3 checks passed
@illicitonion illicitonion deleted the cargo-toml-vars-crate_universe branch March 11, 2025 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants