Use fake.rs not /dev/null as fake source file #2851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We store in the lockfile the path of this source file relative to the package, and if we use an absolute path we end up encoding the depth of your local git clone into the lockfile, which is non-determinstic across machines. Elsewhere we use fake.rs, let's use it here as well.
Merged
UebelAndre
approved these changes
Sep 10, 2024
|
Thanks! Maybe this is something we should warn users about if it leads to non-reproducible outputs on different machines. |
|
@illicitonion looks like CI failed 😞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We store in the lockfile the path of this source file relative to the
package, and if we use an absolute path we end up encoding the depth of
your local git clone into the lockfile, which is non-determinstic across
machines.
Elsewhere we use fake.rs, let's use it here as well.