Add fake dependency roots for all transitive proc-macros #2749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illicitonion
force-pushed
the
musl-proc-macros
branch
from
79535d5
to
3cc0ab7
Compare
illicitonion
changed the title
illicitonion
force-pushed
the
musl-proc-macros
branch
5 times, most recently
from
73da7e3
to
0acf6a4
Compare
illicitonion
force-pushed
the
musl-proc-macros
branch
3 times, most recently
from
4f2de2c
to
b1ae794
Compare
illicitonion
force-pushed
the
musl-proc-macros
branch
3 times, most recently
from
ff901d3
to
066dc8a
Compare
See the extensive comment for details, but tl;dr: when cross-compiling, just doing top-level resolves of direct dependencies can miss resolving platform-specific features for proc-macros which are only used on certain platforms. Also, reliably pass require options to cargo metadata We should always pass -Zbindeps if nightly. All callers should also pass a manifest path and a working directory - ensure they are set.
illicitonion
force-pushed
the
musl-proc-macros
branch
from
066dc8a
to
bf84ddf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the extensive comment for details, but tl;dr: when cross-compiling,
just doing top-level resolves of direct dependencies can miss resolving
platform-specific features for proc-macros which are only used on
certain platforms.