-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added logging to crate_universe checksum validation #2657
Conversation
be585d4
to
bc6b121
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super useful, thanks!
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [rules_rust](https://togithub.com/bazelbuild/rules_rust) | http_archive | minor | `0.44.0` -> `0.45.0` | --- ### Release Notes <details> <summary>bazelbuild/rules_rust (rules_rust)</summary> ### [`v0.45.0`](https://togithub.com/bazelbuild/rules_rust/releases/tag/0.45.0) [Compare Source](https://togithub.com/bazelbuild/rules_rust/compare/0.44.0...0.45.0) ### 0.45.0 ```python load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "rules_rust", integrity = "sha256-0IoZbO7cp5obgv01ucsnAjrWdGpBasntBusUXtdj1aY=", urls = ["https://github.com/bazelbuild/rules_rust/releases/download/0.45.0/rules_rust-v0.45.0.tar.gz"], ) ``` Additional documentation can be found at: https://bazelbuild.github.io/rules_rust/#setup #### What's Changed - Fix cc_common_link when using sibling repository layout by [@​yuzhy8701](https://togithub.com/yuzhy8701) in [https://github.com/bazelbuild/rules_rust/pull/2643](https://togithub.com/bazelbuild/rules_rust/pull/2643) - Allow runfiles object to be an arbitrary expression. by [@​matts1](https://togithub.com/matts1) in [https://github.com/bazelbuild/rules_rust/pull/2651](https://togithub.com/bazelbuild/rules_rust/pull/2651) - Allow searching for the rlocation of a module. by [@​matts1](https://togithub.com/matts1) in [https://github.com/bazelbuild/rules_rust/pull/2652](https://togithub.com/bazelbuild/rules_rust/pull/2652) - Add support for generated sources to rust-analyzer. by [@​matts1](https://togithub.com/matts1) in [https://github.com/bazelbuild/rules_rust/pull/2654](https://togithub.com/bazelbuild/rules_rust/pull/2654) - Added logging to crate_universe checksum validation by [@​UebelAndre](https://togithub.com/UebelAndre) in [https://github.com/bazelbuild/rules_rust/pull/2657](https://togithub.com/bazelbuild/rules_rust/pull/2657) - Release 0.45.0 by [@​UebelAndre](https://togithub.com/UebelAndre) in [https://github.com/bazelbuild/rules_rust/pull/2658](https://togithub.com/bazelbuild/rules_rust/pull/2658) #### New Contributors - [@​yuzhy8701](https://togithub.com/yuzhy8701) made their first contribution in [https://github.com/bazelbuild/rules_rust/pull/2643](https://togithub.com/bazelbuild/rules_rust/pull/2643) **Full Changelog**: bazelbuild/rules_rust@0.44.0...0.45.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/bazel-contrib/toolchains_llvm). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjMuNSIsInVwZGF0ZWRJblZlciI6IjM3LjM2My41IiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Crap!
if result.stdout.strip().lower() == "repin": |
This should be
if result.return_code:
@illicitonion would you be able to do me a huge favor and put up a fix for this and cut a new release? I won’t be available to author a change for some time and this is pretty breaking :(
When
CARGO_BAZEL_DEBUG=1
is enabled, the following log lines will print when determining repins.