-
Notifications
You must be signed in to change notification settings - Fork 507
Add support for UEFI targets and OS #2142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine for whenever the upstream PR merges 😄
Thank you!
I've opened a new upstream PR (bazelbuild/platforms#97) since the original one seems to be abandoned. |
That PR is not really abandoned, it has approval and is waiting for someone on the Bazel team to merge it (I'm the person who did both PRs). |
I'll rebase this either this week or early next one, then we can merge it now that the platform constraint has been merged upstream. |
5af23a6
to
956ce02
Compare
I was able to overcome this by adding "platforms" to MODULE.bazel instead. Sorry for the noise. |
Requires bazelbuild/platforms#76