Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bindgen rules to build clang from source. #1996

Closed
wants to merge 4 commits into from

Conversation

UebelAndre
Copy link
Collaborator

@UebelAndre UebelAndre commented Jun 7, 2023

Github is having weird issues with this pull-request and stopped showing updates. I've closed it and opened a new one here #1998



This change updates the default rust_bindgen rules to build libclang and clang from source using the Bazel rules sourced in the llvm-project repository for use in RustBindgen actions. The version of Clang that Bindgen uses by default is updated 14.0.6 which was what I was able to get building.

Some breaking changes include:

  • Users must now load one extra bzl file if they don't already have have llvm-project defined in their WORKSPACE.
load("@rules_rust//bindgen:transitive_repositories.bzl", "rust_bindgen_transitive_dependencies")

rust_bindgen_transitive_dependencies()
  • rust_bindgen_repositories is deleted as a means of forcing users to take a look at the updated dependencies.

closes #919

@UebelAndre UebelAndre force-pushed the bindgen branch 3 times, most recently from fea53af to 0834f20 Compare June 7, 2023 14:38
@UebelAndre UebelAndre marked this pull request as ready for review June 7, 2023 16:34
@UebelAndre UebelAndre marked this pull request as draft June 7, 2023 16:37
@UebelAndre UebelAndre closed this Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bindgen rules are not supported on all platforms
1 participant