Deleted "extra workspace member" functionality from crate_universe #1406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UebelAndre
force-pushed
the
no-extra-workspace-member
branch
3 times, most recently
from
4195847 to
97c7d4f
Compare
UebelAndre
force-pushed
the
no-extra-workspace-member
branch
from
97c7d4f to
e529abe
Compare
illicitonion
approved these changes
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This functionality was originally needed to handle binary only crates (crates which do not have a library in the same package either implicitly or explicitly). "Extra workspace members" were crates downloaded and added as a workspace member so
crate_universecould generate a dependency graph with that crate included.However, given the recent implementation of #1381 and the existing example of //examples/crate_universe/cargo_remote, there's support and examples for this outside of needing to have the "extra workspace member" functionality built into
crate_universe.Instead of relying on this bespoke functionality, Cargo has recently added support for binary dependencies (rust-lang/cargo#9096). This functionality should provide a much better solution going forward.