Multiple proto generation/linking causing compilation issue

[dfreese]

I've tried to put a minimally reproducible example of the problem I was running into here

When going from commit 5c0e90a to commit 7cde1e46, via #240, I was getting compilation errors, of

the trait bound `server::EchoImpl: echo_rust_grpc_proto::Echo` is not satisfied

when importing a server implementation from another file that's trying to create a gRPC/protobuf server. This is using the rust_library, rust_executable, proto_library, and rust_grpc_library rules.

The compilation between those two different commits seems nearly identical, but in the failing case, the SUBCOMMAND: # //proto:echo_proto seems to be run twice, and then linked into the executable twice.

I'm new to rust. Is this something incorrect in that workspace setup, or is something else going wrong?

[dfreese]

And I should note that I see this same issue at master as well, the commits are the result of a bisect.

[charlesfoo]

+1, seeing the same issue when building in bin/ directory using commit 7cde1e4

[dfreese]

Following up with this, commenting out these two sections in //rust/private/rust.bzl removes the problem. A similar strategy of commenting out this section and this line works on master.

[colinmerkel-th]

Seems like the same problem described in #294

[dfreese]

@colinmerkel-th thanks for pointing that out. I didn't think to look into PRs. That's a much cleaner example.