Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle python/Python dir/file in toolchain archive #805

Closed
wants to merge 6 commits into from

Conversation

fishcakez
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

For python 3.8.10 on macos there is a Python directory in the python static archive. This conflicts with the symlink added in #782. Note that bazel "incorrectly" caches the repository tests so they may not run if the test code itself didn't change even if the repository rules do.

Issue Number: N/A

What is the new behavior?

Delete python directory/file before creating a symlink and tests pass.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

We should look to ensure that repository integration tests aren't incorrectly cached for the toolchain in CI.

@google-cla
Copy link

google-cla bot commented Aug 26, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@fishcakez
Copy link
Contributor Author

Will fix the CLA issue next week.
buildkite is failing because require the fix of #803. Note the bug wasn't caught by CI because of #806.

@fishcakez fishcakez changed the title Handle python/Python dir/file in repository archive Handle python/Python dir/file in toolchain archive Aug 31, 2022
@f0rmiga
Copy link
Collaborator

f0rmiga commented Nov 2, 2022

Sorry, I missed this PR. It ended up getting fixed here 2cdad9e as I extracted the fix from the bigger change I was doing in 26526a5.

@f0rmiga f0rmiga closed this Nov 2, 2022
@fishcakez fishcakez deleted the rm-Python branch November 2, 2022 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants