-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore __pycache__
contents and *.pyc
files in external dependencies
#570
Conversation
Hm, this only excludes it from |
I'm on mobile now but I think it'd make sense to exclude them from |
Doesn't look like I have permission to push, these were my changes:
|
@mattem Ah, I thought you were a maintainer here, makes sense then. I picked up the only the additional exclude for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks correct to me.
Would still like to hear @mattem's response to this if you don't mind 😄 |
PR Checklist
Please check if your PR fulfills the following requirements:
.par
files. See CONTRIBUTING.md for infoPR Type
What kind of change does this PR introduce?
What is the current behavior?
I noticed in some of my builds were getting a bunch of unexpected cache misses and found that some pypi dependencies were including some
__pycache__
contents and left-over*.pyc
files. I don't believe these are needed or should ever be used by the Bazel rules.Issue Number: N/A
What is the new behavior?
This PR prevents these files from being included in the
pip_parse
andpip_install
generatedpy_library
targets.Does this PR introduce a breaking change?
Other information