Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove references to @rules_cc//cc:defs.bzl #2293

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

comius
Copy link
Contributor

@comius comius commented Oct 11, 2024

Referring to @rules_cc//cc:defs.bzl, refers to @protobuf//bazel:cc_proto_library.bzl, which fetches protobuf repository.
Referring directly to what's needed limits the fetches just to rules_cc.

Fix reference to bzl libs in rules_cc that are needed for docs generation.

@meteorcloudy
Copy link
Member

I don't see any reason the RBE jobs have to build with Bazel 6.4.0 and ubuntu1604, please upgrade to Bazel 7.3.2 and ubuntu2204

@rickeylev
Copy link
Contributor

We still support Bazel 6, so we should have an RBE for that. Do you mean for the Bazel 7 RBE job? It looks like its using 7.1 (which is a bit surprising; I thought our CI was setup to use 7.x, i.e. latest 7)

@meteorcloudy
Copy link
Member

I'm not sure which one is the Bazel 7 RBE job, but the for those RBE jobs, you should upgrade to rbe_ubuntu2004.

If Bazel 6 is still supported, then we need to fix rules_cc, sent bazelbuild/rules_cc#253

@aignas
Copy link
Collaborator

aignas commented Oct 13, 2024

FYI, once bazel 8 is out, we will start removing support for bazel 6, but if we can maintain compatibility in an easy way that wouldn't hurt. As for bazel version, we are defining it in .bazelversion in the rules_python repo, maybe we should remove that file to instead test with the latest available stable version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants