Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Improve exec error handling #1368

Merged
merged 4 commits into from
Aug 10, 2023
Merged

feat: Improve exec error handling #1368

merged 4 commits into from
Aug 10, 2023

Commits on Aug 9, 2023

  1. feat: Improve exec binary error handling 

    At times binaries are not in the path. This commit
uses a new method to test that a binary exists before we
try to execute the binary. The method fails with a message
if the binary does not exist.
    @chrislovecnm
    chrislovecnm committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    83b9b4b View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2023

  1. Update python/private/which.bzl 

    Add quotes around command name
    @rickeylev
    rickeylev authored Aug 10, 2023
    Configuration menu
    Copy the full SHA
    a835bdc View commit details
    Browse the repository at this point in the history

  2. Update python/private/which.bzl 

    Pull fail() call out into its own line/block
    @rickeylev
    rickeylev authored Aug 10, 2023
    Configuration menu
    Copy the full SHA
    1342c8b View commit details
    Browse the repository at this point in the history

  3. Update python/private/which.bzl 

    Add missing parentheses to fix syntax error
    @rickeylev
    rickeylev authored Aug 10, 2023
    Configuration menu
    Copy the full SHA
    201a6eb View commit details
    Browse the repository at this point in the history