Skip to content

Overridable debuginfo type #945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

nicbadiu
Copy link
Contributor

This change enables the override of the auto-detected /etc/os-release-based debuginfo type and allows the auto-detection by means of a new default option.

This also enables the use of none as an override option.

@nicbadiu nicbadiu requested a review from nacl as a code owner March 12, 2025 09:16
@nicbadiu nicbadiu force-pushed the patch-3 branch 2 times, most recently from 15732c6 to 4ea728f Compare March 12, 2025 09:22
@nicbadiu nicbadiu requested review from aiuto and cgrindel as code owners March 12, 2025 09:22
This change enables the override of the auto-detected `/etc/os-release`-based
`debuginfo` type and allows the auto-detection by means of a new  `default`
option.

This also enables the use of` none` as an override option.
@tonyaiuto
Copy link
Collaborator

@kellyma2 Do you want to take a look at it.

@nicbadiu Can you provide a description of the API change in the PR description?
Are you able to update the docs too? See the How To of doc_build/BUILD

@@ -57,6 +57,9 @@ def _parse_release_info(release_info):

return os_name, os_version

DEBUGINFO_TYPE_DEFAULT = "default"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should call this DEBUGINFO_TYPE_AUTODETECT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants