Skip to content

Rename pkg_mklink.src to target #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jan 20, 2022
Merged

Rename pkg_mklink.src to target #496

merged 14 commits into from
Jan 20, 2022

Conversation

aiuto
Copy link
Collaborator

@aiuto aiuto commented Dec 24, 2021

Fixed #480

@aiuto aiuto requested a review from nacl as a code owner December 24, 2021 01:30
nacl
nacl approved these changes Jan 20, 2022
View reviewed changes
Copy link
Collaborator

@nacl nacl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I wonder if some more could be done here too. See comments.

@aiuto aiuto merged commit 4fa18d1 into bazelbuild:main Jan 20, 2022
@aiuto aiuto deleted the i480 branch January 20, 2022 23:19
@nacl nacl mentioned this pull request Feb 10, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nacl nacl nacl approved these changes

@floriographygoth floriographygoth Awaiting requested review from floriographygoth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adjust attribute names to better match style guide (e.g. src in pkg_mklink)
2 participants
@aiuto @nacl