Stop passing source jars in kt_jvm_import() to the DefaultInfo(files=) attribute. #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgruber
added
type: bug
cgruber
requested review from
djwhang,
git-str,
jin,
thomaswk and
timpeut
as code owners
|
I removed the usual reviewers, since this isn't up for review/acceptance, but for comment. |
|
For the record, the example is a bit complex, to try to force a few scenarios - direct depending on a kt library, adding an intervening java target, etc. the |
|
Never mind, I found the bug, even though I can't replicate it. |
Kernald
reviewed
Oct 25, 2019
cgruber
force-pushed
the
fix_regression
branch
from
74b04ec
to
2fcece4
Compare
cgruber
changed the title
|
Ok, This should reproduce (and fix) the problem, and is suitable for review now. |
|
Thanks for the fix! I confirm that it fixes #208 for me. |
cgruber
force-pushed
the
fix_regression
branch
2 times, most recently
from
328d33d
to
8149f92
Compare
jin
approved these changes
Oct 28, 2019
jin
reviewed
Oct 28, 2019
jin
reviewed
Oct 28, 2019
…ld on a `build test //...` style call.
…which gets used in places to imply the compile deps, not all the files produced by the rule (such as source jars). This gets fed into the incremental dexing inputs in the android rules, resuling in bazelbuild#208 (which this commit should fix).
… the android sdk stuff
cgruber
force-pushed
the
fix_regression
branch
from
d4e2ecc
to
c44191e
Compare
cgruber
added a commit
to cgruber/rules_kotlin
that referenced
this pull request
Oct 29, 2019
Also delete most of the readme. * upstream/master: Add recent changes to changelog. Update README.md to account for 1.3.0-rc1 release. Stop passing source jars in kt_jvm_import() to the DefaultInfo(files=) attribute. (bazelbuild#221) Use a comma to separate friends-paths, as kotlinc extracts friends path elements using that separator, not the usual system path separator. (bazelbuild#222) Use regular expressions to match JS filenames in kt_js_import. (bazelbuild#223) Fix builder crashes (bazelbuild#217) Remove use of named parameter that has been disabled in starlark (only the positional usage is permitted now). (bazelbuild#215) Add a facility for inferring the test class from the test name, if no test_class is specified, similar to the java_test rule. (bazelbuild#209) Update readme URL (bazelbuild#207) Newline at end of file, per review comment. remove unused import. Remove script which (a) isn't needed given the CI matrix, and (b) has already been moved to another repo. Fixes to the readme, per code review. Update scripts/test_version_utils.kt Move a chunk of the new/log into the CHANGELOG.md, and trim. Add a changelog/newslog Fix contributing doc. A bit of formatting on the readme. Update readme in preparation for upstreaming.
jongerrish
added a commit
to jongerrish/rules_kotlin
that referenced
this pull request
Apr 16, 2020
…) attribute. (bazelbuild#221) * Don't include the source jar in the default info's files= attribute, which gets used in places to imply the compile deps, not all the files produced by the rule (such as source jars). This gets fed into the incremental dexing inputs in the android rules, resuling in bazelbuild#208 (which this commit should fix). * Add in an android application example with a `build_test()` and a CI pipeline to build/test it. Also normalize examples naming in CI. * Use the preferred form for kt_jvm_import in the core bits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DefaultInfo(files=) gets passed to various things that interpret it as regular outputs, such as production jars, so things like source jars should not go in it.
Fixes #208