fix(compile): add missing GOAMD64 and GOARM env values in goctx.env_for_path_mapping #4121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbcjbb
commented
Sep 26, 2024
|
Thanks for sending the fix, I see how I broke this. |
lbcjbb
force-pushed
the
fix-build-amd64-v3
branch
from
a6332fd
to
8894518
Compare
fmeum
reviewed
Sep 26, 2024
lbcjbb
force-pushed
the
fix-build-amd64-v3
branch
2 times, most recently
from
107b4b4
to
3e5573d
Compare
fmeum
approved these changes
Sep 26, 2024
fmeum
force-pushed
the
fix-build-amd64-v3
branch
from
3e5573d
to
88ead88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
The
env_for_path_mappingattribut of the go context should contain theGOAMD64andGOARMenv values.Which issues(s) does this PR fix?
Fixes #4119