Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make go_reset_target public #3965

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

tyler-french
Copy link
Contributor

go_reset_target is helpful when certain plugins or tool attributes to rules can't build under certain configurations. For example, many thrift plugins fail to build when a dependency of a go_binary with c-shared instrumentation.

To alleviate this issue, you can pass the tool to go_reset_target.

Copy link
Collaborator

@fmeum fmeum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I generally support this, we should thus make sure that the docs comment makes sense for external users.

go/private/rules/transition.bzl Outdated Show resolved Hide resolved
go/private/rules/transition.bzl Outdated Show resolved Hide resolved
@tyler-french tyler-french force-pushed the reset-target branch 2 times, most recently from fed9c39 to 8a6344e Compare July 9, 2024 16:50
@tyler-french tyler-french requested a review from fmeum July 9, 2024 16:50
@tyler-french tyler-french marked this pull request as ready for review July 9, 2024 16:50
@tyler-french tyler-french force-pushed the reset-target branch 2 times, most recently from 423435c to 762b419 Compare July 10, 2024 19:09
@tyler-french tyler-french requested a review from linzhp July 13, 2024 15:18
@tyler-french tyler-french enabled auto-merge (squash) August 28, 2024 01:29
@tyler-french tyler-french merged commit 4a8e603 into bazelbuild:master Aug 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants