Update to modern protoc plugins #3761

mering · 2023-11-21T15:22:21Z

What type of PR is this?

Update

What does this PR do? Why is it needed?

The module github.com/golang/protobuf has been superseded by the google.golang.org/protobuf and google.golang.org/grpc modules, which contain an updated and simplified API, support for protobuf reflection, and many other improvements.

The go_grpc_library() macro maintains the current behavior of generating both the proto and the service definitions.

Which issues(s) does this PR fix?

Fixes #3022

Supercedes #3437, #3783

Other notes for review

mering · 2023-11-24T09:20:37Z

@fmeum There is a BCR build failure:

ERROR: C:/b/bxkbc7u6/external/rules_go~override/proto/BUILD.bazel:31:18: no such package '@gazelle~0.34.0~go_deps~org_golang_google_grpc//cmd/protoc-gen-go-grpc': BUILD file not found in directory 'cmd/protoc-gen-go-grpc' of external repository @gazelle~0.34.0~go_deps~org_golang_google_grpc. Add a BUILD file to a directory to mark it as a package. and referenced by '@rules_go~override//proto:go_grpc_reset_plugin_'

Do I see it correctly that this is because the bzlmod dependency doesn't have build_file_generation = "on" set which can only be corrected by an upstream PR to Gazelle like bazelbuild/bazel-gazelle#1672?

fmeum · 2023-12-13T11:27:05Z

I pushed a commit with the required releaser changes.

mering · 2023-12-13T12:30:29Z

I pushed a commit with the required releaser changes.

Awesome, thanks a lot!

to org_golang_google_protobuf and org_golang_google_grpc.

…pc code

ryanpbrewster · 2023-12-18T23:05:31Z

@fmeum do you think we can get a fresh release out with this protoc plugin? Would be nice to give folks a chance to start trying it out.

fmeum · 2023-12-19T08:30:40Z

#3788

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io_bazel_rules_go](https://togithub.com/bazelbuild/rules_go) | http_archive | minor | `v0.43.0` -> `v0.44.0` | --- ### Release Notes <details> <summary>bazelbuild/rules_go (io_bazel_rules_go)</summary> ### [`v0.44.0`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.44.0) [Compare Source](https://togithub.com/bazelbuild/rules_go/compare/v0.43.0...v0.44.0) ### IMPORTANT CHANGES #### Tests now call `panic()` when they timeout This means there is a running goroutine (which will fail [goleak](https://togithub.com/uber-go/goleak) detection) [Goroutine 26 in state chan receive, with github.com/bazelbuild/rules_go/go/tools/bzltestutil.RegisterTimeoutHandler.func1 on top of the This also means there may be some different behavior when calling `SIGTERM` directly from within a test. For more information see: [https://github.com/bazelbuild/rules_go/pull/3749](https://togithub.com/bazelbuild/rules_go/pull/3749) #### Bzlmod support for `nogo` This can be added in your `MODULE.bazel` file: go_sdk = use_extension("@io_bazel_rules_go//go:extensions.bzl", "go_sdk") go_sdk.download( name = "go_sdk", ... ) go_sdk.nogo( nogo = "//:default_nogo", ) For more information see [https://github.com/bazelbuild/rules_go/pull/3782](https://togithub.com/bazelbuild/rules_go/pull/3782) #### `WORKSPACE` code load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "io_bazel_rules_go", sha256 = "c8035e8ae248b56040a65ad3f0b7434712e2037e5dfdcebfe97576e620422709", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.44.0/rules_go-v0.44.0.zip", "https://github.com/bazelbuild/rules_go/releases/download/v0.44.0/rules_go-v0.44.0.zip", ], ) load("@io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies") go_rules_dependencies() go_register_toolchains(version = "1.21.5") #### What's Changed - Do not test on centos7 by [@fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3757](https://togithub.com/bazelbuild/rules_go/pull/3757) - update documentation for 0.43.0 release by [@tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/rules_go/pull/3758](https://togithub.com/bazelbuild/rules_go/pull/3758) - Add toolchain param to affected actions by [@kotlaja](https://togithub.com/kotlaja) in [https://github.com/bazelbuild/rules_go/pull/3760](https://togithub.com/bazelbuild/rules_go/pull/3760) - Update GO_TOOLCHAIN string to Label and add toolchain param to one more action by [@kotlaja](https://togithub.com/kotlaja) in [https://github.com/bazelbuild/rules_go/pull/3762](https://togithub.com/bazelbuild/rules_go/pull/3762) - Do not choose prereleases as highest versions by [@mering](https://togithub.com/mering) in [https://github.com/bazelbuild/rules_go/pull/3764](https://togithub.com/bazelbuild/rules_go/pull/3764) - Remove unmaintained validators by [@mering](https://togithub.com/mering) in [https://github.com/bazelbuild/rules_go/pull/3768](https://togithub.com/bazelbuild/rules_go/pull/3768) - Use `tools.go` trick to make `go.mod` work with `go mod tidy` by [@fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3775](https://togithub.com/bazelbuild/rules_go/pull/3775) - feat(packagesdriver): add \_test suffix to pkgPath by [@JamyDev](https://togithub.com/JamyDev) in [https://github.com/bazelbuild/rules_go/pull/3777](https://togithub.com/bazelbuild/rules_go/pull/3777) - Typo --test_runner_fail_fast by [@Clement-Jean](https://togithub.com/Clement-Jean) in [https://github.com/bazelbuild/rules_go/pull/3773](https://togithub.com/bazelbuild/rules_go/pull/3773) - Panic when a test times out by [@fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3749](https://togithub.com/bazelbuild/rules_go/pull/3749) - Fix integration tests with Bazel@HEAD by [@fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3781](https://togithub.com/bazelbuild/rules_go/pull/3781) - Automatically register SDKs for common execution platforms by [@fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3634](https://togithub.com/bazelbuild/rules_go/pull/3634) - fix `aux_files` relative paths for gomock source mocks (fix [#3752](https://togithub.com/bazelbuild/rules_go/issues/3752)) by [@ikavalio](https://togithub.com/ikavalio) in [https://github.com/bazelbuild/rules_go/pull/3753](https://togithub.com/bazelbuild/rules_go/pull/3753) - Update to modern protoc plugins by [@mering](https://togithub.com/mering) in [https://github.com/bazelbuild/rules_go/pull/3761](https://togithub.com/bazelbuild/rules_go/pull/3761) - Add integration tests for protoc-gen-go-grpc by [@ryanpbrewster](https://togithub.com/ryanpbrewster) in [https://github.com/bazelbuild/rules_go/pull/3787](https://togithub.com/bazelbuild/rules_go/pull/3787) - Add Bzlmod support for `nogo` by [@fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3782](https://togithub.com/bazelbuild/rules_go/pull/3782) - fix(gpd): don't panic on invalid root by [@JamyDev](https://togithub.com/JamyDev) in [https://github.com/bazelbuild/rules_go/pull/3779](https://togithub.com/bazelbuild/rules_go/pull/3779) - Pass env to gentestmain so it will correctly filter by [@patrickmscott](https://togithub.com/patrickmscott) in [https://github.com/bazelbuild/rules_go/pull/3785](https://togithub.com/bazelbuild/rules_go/pull/3785) - prepare release 0.44.0 by [@tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/rules_go/pull/3788](https://togithub.com/bazelbuild/rules_go/pull/3788) #### New Contributors - [@Clement-Jean](https://togithub.com/Clement-Jean) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3773](https://togithub.com/bazelbuild/rules_go/pull/3773) - [@ikavalio](https://togithub.com/ikavalio) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3753](https://togithub.com/bazelbuild/rules_go/pull/3753) - [@ryanpbrewster](https://togithub.com/ryanpbrewster) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3787](https://togithub.com/bazelbuild/rules_go/pull/3787) **Full Changelog**: bazelbuild/rules_go@v0.43.0...v0.44.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).  Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io_bazel_rules_go](https://togithub.com/bazelbuild/rules_go) | http_archive | minor | `v0.43.0` -> `v0.44.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>bazelbuild/rules_go (io_bazel_rules_go)</summary> ### [`v0.44.0`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.44.0) [Compare Source](https://togithub.com/bazelbuild/rules_go/compare/v0.43.0...v0.44.0) ### IMPORTANT CHANGES #### Tests now call `panic()` when they timeout This means there is a running goroutine (which will fail [goleak](https://togithub.com/uber-go/goleak) detection) [Goroutine 26 in state chan receive, with github.com/bazelbuild/rules_go/go/tools/bzltestutil.RegisterTimeoutHandler.func1 on top of the This also means there may be some different behavior when calling `SIGTERM` directly from within a test. For more information see: [https://github.com/bazelbuild/rules_go/pull/3749](https://togithub.com/bazelbuild/rules_go/pull/3749) #### Bzlmod support for `nogo` This can be added in your `MODULE.bazel` file: go_sdk = use_extension("@io_bazel_rules_go//go:extensions.bzl", "go_sdk") go_sdk.download( name = "go_sdk", ... ) go_sdk.nogo( nogo = "//:default_nogo", ) For more information see [https://github.com/bazelbuild/rules_go/pull/3782](https://togithub.com/bazelbuild/rules_go/pull/3782) #### `WORKSPACE` code load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "io_bazel_rules_go", sha256 = "c8035e8ae248b56040a65ad3f0b7434712e2037e5dfdcebfe97576e620422709", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.44.0/rules_go-v0.44.0.zip", "https://github.com/bazelbuild/rules_go/releases/download/v0.44.0/rules_go-v0.44.0.zip", ], ) load("@io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies") go_rules_dependencies() go_register_toolchains(version = "1.21.5") #### What's Changed - Do not test on centos7 by [@fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3757](https://togithub.com/bazelbuild/rules_go/pull/3757) - update documentation for 0.43.0 release by [@tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/rules_go/pull/3758](https://togithub.com/bazelbuild/rules_go/pull/3758) - Add toolchain param to affected actions by [@kotlaja](https://togithub.com/kotlaja) in [https://github.com/bazelbuild/rules_go/pull/3760](https://togithub.com/bazelbuild/rules_go/pull/3760) - Update GO_TOOLCHAIN string to Label and add toolchain param to one more action by [@kotlaja](https://togithub.com/kotlaja) in [https://github.com/bazelbuild/rules_go/pull/3762](https://togithub.com/bazelbuild/rules_go/pull/3762) - Do not choose prereleases as highest versions by [@mering](https://togithub.com/mering) in [https://github.com/bazelbuild/rules_go/pull/3764](https://togithub.com/bazelbuild/rules_go/pull/3764) - Remove unmaintained validators by [@mering](https://togithub.com/mering) in [https://github.com/bazelbuild/rules_go/pull/3768](https://togithub.com/bazelbuild/rules_go/pull/3768) - Use `tools.go` trick to make `go.mod` work with `go mod tidy` by [@fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3775](https://togithub.com/bazelbuild/rules_go/pull/3775) - feat(packagesdriver): add \_test suffix to pkgPath by [@JamyDev](https://togithub.com/JamyDev) in [https://github.com/bazelbuild/rules_go/pull/3777](https://togithub.com/bazelbuild/rules_go/pull/3777) - Typo --test_runner_fail_fast by [@Clement-Jean](https://togithub.com/Clement-Jean) in [https://github.com/bazelbuild/rules_go/pull/3773](https://togithub.com/bazelbuild/rules_go/pull/3773) - Panic when a test times out by [@fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3749](https://togithub.com/bazelbuild/rules_go/pull/3749) - Fix integration tests with Bazel@HEAD by [@fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3781](https://togithub.com/bazelbuild/rules_go/pull/3781) - Automatically register SDKs for common execution platforms by [@fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3634](https://togithub.com/bazelbuild/rules_go/pull/3634) - fix `aux_files` relative paths for gomock source mocks (fix [#3752](https://togithub.com/bazelbuild/rules_go/issues/3752)) by [@ikavalio](https://togithub.com/ikavalio) in [https://github.com/bazelbuild/rules_go/pull/3753](https://togithub.com/bazelbuild/rules_go/pull/3753) - Update to modern protoc plugins by [@mering](https://togithub.com/mering) in [https://github.com/bazelbuild/rules_go/pull/3761](https://togithub.com/bazelbuild/rules_go/pull/3761) - Add integration tests for protoc-gen-go-grpc by [@ryanpbrewster](https://togithub.com/ryanpbrewster) in [https://github.com/bazelbuild/rules_go/pull/3787](https://togithub.com/bazelbuild/rules_go/pull/3787) - Add Bzlmod support for `nogo` by [@fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3782](https://togithub.com/bazelbuild/rules_go/pull/3782) - fix(gpd): don't panic on invalid root by [@JamyDev](https://togithub.com/JamyDev) in [https://github.com/bazelbuild/rules_go/pull/3779](https://togithub.com/bazelbuild/rules_go/pull/3779) - Pass env to gentestmain so it will correctly filter by [@patrickmscott](https://togithub.com/patrickmscott) in [https://github.com/bazelbuild/rules_go/pull/3785](https://togithub.com/bazelbuild/rules_go/pull/3785) - prepare release 0.44.0 by [@tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/rules_go/pull/3788](https://togithub.com/bazelbuild/rules_go/pull/3788) #### New Contributors - [@Clement-Jean](https://togithub.com/Clement-Jean) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3773](https://togithub.com/bazelbuild/rules_go/pull/3773) - [@ikavalio](https://togithub.com/ikavalio) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3753](https://togithub.com/bazelbuild/rules_go/pull/3753) - [@ryanpbrewster](https://togithub.com/ryanpbrewster) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3787](https://togithub.com/bazelbuild/rules_go/pull/3787) **Full Changelog**: bazelbuild/rules_go@v0.43.0...v0.44.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/kreempuff/rules_unreal_engine).

com6056 · 2023-12-20T00:17:46Z

proto/def.bzl

-def go_grpc_library(**kwargs):
-    # TODO: Deprecate once gazelle generates just go_proto_library
-    go_proto_library(compilers = [Label("//proto:go_grpc")], **kwargs)
+def go_grpc_library(name, **kwargs):


Should this support passing in additional values for compilers for things like @com_github_grpc_ecosystem_grpc_gateway_v2//protoc-gen-grpc-gateway:go_gen_grpc_gateway?

For custom scenarios I think you can always "drop down" to the lower-level go_proto_library and pass in whatever compilers you want. IMO this method is mostly a matter of convenience for the 90% of use-cases that want these two specific compilers.

Ya totally fair, I only bring it up because the deprecation notice says via go_grpc_library() rule which didn't end up working for us since we use grpc-gateway, so maybe the deprecation message could mention both options to clear up any confusion

That seems entirely reasonable

Suggestion from bazelbuild#3761 (comment)

Suggestion from #3761 (comment)

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io_bazel_rules_go](https://togithub.com/bazelbuild/rules_go) | http_archive | minor | `v0.43.0` -> `v0.44.0` | --- ### Release Notes <details> <summary>bazelbuild/rules_go (io_bazel_rules_go)</summary> ### [`v0.44.0`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.44.0) [Compare Source](https://togithub.com/bazelbuild/rules_go/compare/v0.43.0...v0.44.0) ### IMPORTANT CHANGES #### Tests now call `panic()` when they timeout This means there is a running goroutine (which will fail [goleak](https://togithub.com/uber-go/goleak) detection) [Goroutine 26 in state chan receive, with github.com/bazelbuild/rules_go/go/tools/bzltestutil.RegisterTimeoutHandler.func1 on top of the This also means there may be some different behavior when calling `SIGTERM` directly from within a test. For more information see: [https://github.com/bazelbuild/rules_go/pull/3749](https://togithub.com/bazelbuild/rules_go/pull/3749) #### Bzlmod support for `nogo` This can be added in your `MODULE.bazel` file: go_sdk = use_extension("@io_bazel_rules_go//go:extensions.bzl", "go_sdk") go_sdk.download( name = "go_sdk", ... ) go_sdk.nogo( nogo = "//:default_nogo", ) For more information see [https://github.com/bazelbuild/rules_go/pull/3782](https://togithub.com/bazelbuild/rules_go/pull/3782) #### `WORKSPACE` code load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "io_bazel_rules_go", sha256 = "c8035e8ae248b56040a65ad3f0b7434712e2037e5dfdcebfe97576e620422709", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.44.0/rules_go-v0.44.0.zip", "https://github.com/bazelbuild/rules_go/releases/download/v0.44.0/rules_go-v0.44.0.zip", ], ) load("@io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies") go_rules_dependencies() go_register_toolchains(version = "1.21.5") #### What's Changed - Do not test on centos7 by [@fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3757](https://togithub.com/bazelbuild/rules_go/pull/3757) - update documentation for 0.43.0 release by [@tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/rules_go/pull/3758](https://togithub.com/bazelbuild/rules_go/pull/3758) - Add toolchain param to affected actions by [@kotlaja](https://togithub.com/kotlaja) in [https://github.com/bazelbuild/rules_go/pull/3760](https://togithub.com/bazelbuild/rules_go/pull/3760) - Update GO_TOOLCHAIN string to Label and add toolchain param to one more action by [@kotlaja](https://togithub.com/kotlaja) in [https://github.com/bazelbuild/rules_go/pull/3762](https://togithub.com/bazelbuild/rules_go/pull/3762) - Do not choose prereleases as highest versions by [@mering](https://togithub.com/mering) in [https://github.com/bazelbuild/rules_go/pull/3764](https://togithub.com/bazelbuild/rules_go/pull/3764) - Remove unmaintained validators by [@mering](https://togithub.com/mering) in [https://github.com/bazelbuild/rules_go/pull/3768](https://togithub.com/bazelbuild/rules_go/pull/3768) - Use `tools.go` trick to make `go.mod` work with `go mod tidy` by [@fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3775](https://togithub.com/bazelbuild/rules_go/pull/3775) - feat(packagesdriver): add \_test suffix to pkgPath by [@JamyDev](https://togithub.com/JamyDev) in [https://github.com/bazelbuild/rules_go/pull/3777](https://togithub.com/bazelbuild/rules_go/pull/3777) - Typo --test_runner_fail_fast by [@Clement-Jean](https://togithub.com/Clement-Jean) in [https://github.com/bazelbuild/rules_go/pull/3773](https://togithub.com/bazelbuild/rules_go/pull/3773) - Panic when a test times out by [@fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3749](https://togithub.com/bazelbuild/rules_go/pull/3749) - Fix integration tests with Bazel@HEAD by [@fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3781](https://togithub.com/bazelbuild/rules_go/pull/3781) - Automatically register SDKs for common execution platforms by [@fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3634](https://togithub.com/bazelbuild/rules_go/pull/3634) - fix `aux_files` relative paths for gomock source mocks (fix [#3752](https://togithub.com/bazelbuild/rules_go/issues/3752)) by [@ikavalio](https://togithub.com/ikavalio) in [https://github.com/bazelbuild/rules_go/pull/3753](https://togithub.com/bazelbuild/rules_go/pull/3753) - Update to modern protoc plugins by [@mering](https://togithub.com/mering) in [https://github.com/bazelbuild/rules_go/pull/3761](https://togithub.com/bazelbuild/rules_go/pull/3761) - Add integration tests for protoc-gen-go-grpc by [@ryanpbrewster](https://togithub.com/ryanpbrewster) in [https://github.com/bazelbuild/rules_go/pull/3787](https://togithub.com/bazelbuild/rules_go/pull/3787) - Add Bzlmod support for `nogo` by [@fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3782](https://togithub.com/bazelbuild/rules_go/pull/3782) - fix(gpd): don't panic on invalid root by [@JamyDev](https://togithub.com/JamyDev) in [https://github.com/bazelbuild/rules_go/pull/3779](https://togithub.com/bazelbuild/rules_go/pull/3779) - Pass env to gentestmain so it will correctly filter by [@patrickmscott](https://togithub.com/patrickmscott) in [https://github.com/bazelbuild/rules_go/pull/3785](https://togithub.com/bazelbuild/rules_go/pull/3785) - prepare release 0.44.0 by [@tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/rules_go/pull/3788](https://togithub.com/bazelbuild/rules_go/pull/3788) #### New Contributors - [@Clement-Jean](https://togithub.com/Clement-Jean) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3773](https://togithub.com/bazelbuild/rules_go/pull/3773) - [@ikavalio](https://togithub.com/ikavalio) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3753](https://togithub.com/bazelbuild/rules_go/pull/3753) - [@ryanpbrewster](https://togithub.com/ryanpbrewster) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3787](https://togithub.com/bazelbuild/rules_go/pull/3787) **Full Changelog**: bazelbuild/rules_go@v0.43.0...v0.44.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).  Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>

sluongng · 2024-01-05T17:11:36Z

Tried this out today.

Given this setup https://github.com/buildbuddy-io/buildbuddy/blob/fe06bd31053246afb8a499dea6a9b86633727863/proto/jaeger/BUILD

And this patch

diff --git a/proto/jaeger/BUILD b/proto/jaeger/BUILD
index 7c25d6697..f1f2f2f64 100644
--- a/proto/jaeger/BUILD
+++ b/proto/jaeger/BUILD
@@ -18,7 +18,7 @@ proto_library(

 go_proto_library(
     name = "jaeger_go_proto",
-    compilers = ["@io_bazel_rules_go//proto:go_grpc"],
+    compilers = ["@io_bazel_rules_go//proto:go_grpc_v2"],
     importpath = "github.com/buildbuddy-io/buildbuddy/proto/jaeger",
     proto = ":jaeger_proto",
     deps = [

I got

# Configuration: 3e5db740cb435843d39c6a2b05c6682e49f63f4b0d2fd08653a6c78ecb4166f7
# Execution platform: //platforms:linux_x86_64
bazel-out/linux_x86_64-fastbuild/bin/proto/jaeger/jaeger_go_proto_/github.com/buildbuddy-io/buildbuddy/proto/jaeger/query_grpc.pb.go:21:36: undefined: GetTraceRequest
bazel-out/linux_x86_64-fastbuild/bin/proto/jaeger/jaeger_go_proto_/github.com/buildbuddy-io/buildbuddy/proto/jaeger/query_grpc.pb.go:22:40: undefined: ArchiveTraceRequest
bazel-out/linux_x86_64-fastbuild/bin/proto/jaeger/jaeger_go_proto_/github.com/buildbuddy-io/buildbuddy/proto/jaeger/query_grpc.pb.go:22:88: undefined: ArchiveTraceResponse
bazel-out/linux_x86_64-fastbuild/bin/proto/jaeger/jaeger_go_proto_/github.com/buildbuddy-io/buildbuddy/proto/jaeger/query_grpc.pb.go:23:38: undefined: FindTracesRequest
bazel-out/linux_x86_64-fastbuild/bin/proto/jaeger/jaeger_go_proto_/github.com/buildbuddy-io/buildbuddy/proto/jaeger/query_grpc.pb.go:24:39: undefined: GetServicesRequest
bazel-out/linux_x86_64-fastbuild/bin/proto/jaeger/jaeger_go_proto_/github.com/buildbuddy-io/buildbuddy/proto/jaeger/query_grpc.pb.go:24:86: undefined: GetServicesResponse
bazel-out/linux_x86_64-fastbuild/bin/proto/jaeger/jaeger_go_proto_/github.com/buildbuddy-io/buildbuddy/proto/jaeger/query_grpc.pb.go:25:41: undefined: GetOperationsRequest
bazel-out/linux_x86_64-fastbuild/bin/proto/jaeger/jaeger_go_proto_/github.com/buildbuddy-io/buildbuddy/proto/jaeger/query_grpc.pb.go:25:90: undefined: GetOperationsResponse
bazel-out/linux_x86_64-fastbuild/bin/proto/jaeger/jaeger_go_proto_/github.com/buildbuddy-io/buildbuddy/proto/jaeger/query_grpc.pb.go:53:11: undefined: SpansResponseChunk
bazel-out/linux_x86_64-fastbuild/bin/proto/jaeger/jaeger_go_proto_/github.com/buildbuddy-io/buildbuddy/proto/jaeger/query_grpc.pb.go:94:11: undefined: SpansResponseChunk
bazel-out/linux_x86_64-fastbuild/bin/proto/jaeger/jaeger_go_proto_/github.com/buildbuddy-io/buildbuddy/proto/jaeger/query_grpc.pb.go:25:90: too many errors
compilepkg: error running subcommand external/go_sdk_linux/pkg/tool/linux_amd64/compile: exit status 2

Reverted to v1 and everything just works.

ryanpbrewster · 2024-01-05T17:18:09Z

I think you need two compilers:

[
  "@io_bazel_rules_go//proto:go_proto",
  "@io_bazel_rules_go//proto:go_grpc_v2",
]

That's what the go_grpc_library helper does (I believe it's convenience wrapper around go_proto_library that automatically configures those two compilers.

sluongng · 2024-01-05T17:54:09Z

Thanks @ryanpbrewster for the tip! It worked after including :go_proto compiler.

But it seems like most of our go_proto_library targets are under Gazelle control.

So a simple gazelle run would revert all the changes as follow

-load("@io_bazel_rules_go//proto:def.bzl", "go_grpc_library")
+load("@io_bazel_rules_go//proto:def.bzl", "go_proto_library")

 # gazelle:default_visibility //enterprise/server/test/integration/remote_execution:__subpackages__
 package(default_visibility = [
@@ -11,8 +11,9 @@ proto_library(
     srcs = ["remote_execution_test.proto"],
 )

-go_grpc_library(
+go_proto_library(
     name = "remoteexecutiontest_go_proto",
+    compilers = ["@io_bazel_rules_go//proto:go_grpc"],
     importpath = "github.com/buildbuddy-io/buildbuddy/enterprise/server/test/integration/remote_execution/proto",
     proto = ":remoteexecutiontest_proto",
 )

So the deprecation was merged a bit too early. Ideally, it should be merged only after bazelbuild/bazel-gazelle#1711

mering · 2024-01-05T18:02:36Z

@sluongng https://github.com/golang/protobuf has been superceded by the new compilers 4 years ago. So I would argue the deprecation warning in this repo was actually rather late than early.

ryanpbrewster · 2024-01-05T18:10:16Z

For anyone else that finds there way to this PR because they are fighting with gazelle: you can add this directive to a BUILD file and it will affect all subpackages:

# gazelle:go_grpc_compilers	@io_bazel_rules_go//proto:go_proto,@io_bazel_rules_go//proto:go_grpc_v2

This instructs gazelle to install the appropriate compilers

sluongng · 2024-01-08T10:43:40Z

@mering I am not opposed to upgrading to the new compiler in rules_go and gazelle. However, we should not mark the compiler in rules_go as deprecated until the new compiler is on feature parity with the old compiler (i.e. Gazelle support).

It reminds me of this Goomics https://goomics.net/50/ that folks often share with me when adopting Google's APIs/tools. And it would cost us little to make it happen (deplaying the rules_go release a bit more until the Gazelle change was merged).

@ryanpbrewster that's a useful workaround. Thanks! I hope bazelbuild/bazel-gazelle#1711 will make it obsolete. 🤞

mering force-pushed the update-protoc-plugins branch 25 times, most recently from 2a2c76c to 7114512 Compare November 24, 2023 09:12

mering force-pushed the update-protoc-plugins branch 4 times, most recently from 3fa61e5 to 04cb3b6 Compare November 24, 2023 11:27

tyler-french approved these changes Dec 14, 2023

View reviewed changes

mering and others added 4 commits December 14, 2023 08:36

Move away from deprecated com_github_golang_protobuf

57f8c41

to org_golang_google_protobuf and org_golang_google_grpc.

Restore previous behavior where grpc rule generates both proto and gr…

f5bd13f

…pc code

Suggest smooth migration path without breaking existing workflows

e90868d

Support submodules in releaser

17793d7

fmeum force-pushed the update-protoc-plugins branch from 8d2e656 to 17793d7 Compare December 14, 2023 07:36

fmeum enabled auto-merge (squash) December 14, 2023 07:36

fmeum merged commit 5df0c5e into bazelbuild:master Dec 14, 2023
2 checks passed

mering deleted the update-protoc-plugins branch December 14, 2023 09:24

ryanpbrewster mentioned this pull request Dec 14, 2023

Add integration tests for protoc-gen-go-grpc #3787

Merged

com6056 reviewed Dec 20, 2023

View reviewed changes

ryanpbrewster added a commit to ryanpbrewster/rules_go that referenced this pull request Dec 20, 2023

Slightly tweak deprecation wording for //proto:go_grpc

8d0d555

Suggestion from bazelbuild#3761 (comment)

ryanpbrewster mentioned this pull request Dec 20, 2023

Slightly tweak deprecation wording for //proto:go_grpc #3790

Merged

fmeum pushed a commit that referenced this pull request Dec 20, 2023

Slightly tweak deprecation wording for //proto:go_grpc (#3790)

9adc8e1

Suggestion from #3761 (comment)

jmhodges mentioned this pull request Jan 4, 2024

gazelle generates and recreates grpc targets that rules_go complains about bazelbuild/bazel-gazelle#1709

Open

sluongng mentioned this pull request Jan 5, 2024

Upgrade rules_go and gazelle buildbuddy-io/buildbuddy#5655

Merged

sluongng mentioned this pull request Jan 8, 2024

proto: handle go proto library deprecation buildbuddy-io/buildbuddy#5662

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to modern protoc plugins #3761

Update to modern protoc plugins #3761

mering commented Nov 21, 2023 •

edited

Loading

mering commented Nov 24, 2023

fmeum commented Dec 13, 2023

mering commented Dec 13, 2023

ryanpbrewster commented Dec 18, 2023

fmeum commented Dec 19, 2023

com6056 Dec 20, 2023

ryanpbrewster Dec 20, 2023

com6056 Dec 20, 2023

ryanpbrewster Dec 20, 2023

sluongng commented Jan 5, 2024

ryanpbrewster commented Jan 5, 2024

sluongng commented Jan 5, 2024

mering commented Jan 5, 2024

ryanpbrewster commented Jan 5, 2024

sluongng commented Jan 8, 2024

Update to modern protoc plugins #3761

Update to modern protoc plugins #3761

Conversation

mering commented Nov 21, 2023 • edited Loading

mering commented Nov 24, 2023

fmeum commented Dec 13, 2023

mering commented Dec 13, 2023

ryanpbrewster commented Dec 18, 2023

fmeum commented Dec 19, 2023

com6056 Dec 20, 2023

Choose a reason for hiding this comment

ryanpbrewster Dec 20, 2023

Choose a reason for hiding this comment

com6056 Dec 20, 2023

Choose a reason for hiding this comment

ryanpbrewster Dec 20, 2023

Choose a reason for hiding this comment

sluongng commented Jan 5, 2024

ryanpbrewster commented Jan 5, 2024

sluongng commented Jan 5, 2024

mering commented Jan 5, 2024

ryanpbrewster commented Jan 5, 2024

sluongng commented Jan 8, 2024

mering commented Nov 21, 2023 •

edited

Loading