feat(stdlib): update TAG_AFFECTS_STDLIB dict for Go versions 1.20..1.…

…23 (#4122)
bazelbuild · Sep 26, 2024 · 6c1154a · 6c1154a
1 parent d37da53
commit 6c1154a
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 8 deletions.
diff --git a/go/private/rules/transition.bzl b/go/private/rules/transition.bzl
@@ -446,25 +446,30 @@ go_cross_transition = transition(
 # This should be updated to contain the union of all tags relevant for all
 # versions of Go that are still relevant.
 #
-# Currently supported versions: 1.18, 1.19, 1.20
+# Currently supported versions: 1.18..1.23
 #
 # To regenerate, run and paste the output of
 #     bazel run //go/tools/internal/stdlib_tags:stdlib_tags -- path/to/go_sdk_1/src ...
 _TAG_AFFECTS_STDLIB = {
     "alpha": None,
     "appengine": None,
     "asan": None,
-    "boringcrypto": None,
+    "boringcrypto": None,  # Added in Go 1.19
+    "checknewoldreassignment": None,  # Added in Go 1.22
     "cmd_go_bootstrap": None,
     "compiler_bootstrap": None,
     "debuglog": None,
+    "debugtrace": None,  # Added in Go 1.22
     "faketime": None,
     "gc": None,
     "gccgo": None,
-    "gen": None,
+    "gen": None,  # Removed in Go 1.20
     "generate": None,
-    "gofuzz": None,
+    "gofuzz": None,  # Removed in Go 1.23
+    "icu": None,  # Added in Go 1.23
     "ignore": None,
+    "internal": None,  # Added in Go 1.21
+    "internal_pie": None,  # Added in Go 1.21, removed in Go 1.22
     "libfuzzer": None,
     "m68k": None,
     "math_big_pure_go": None,
@@ -473,13 +478,15 @@ _TAG_AFFECTS_STDLIB = {
     "netgo": None,
     "nethttpomithttp2": None,
     "nios2": None,
-    "noopt": None,
+    "noopt": None,  # Added in Go 1.20
     "osusergo": None,
     "purego": None,
     "race": None,
     "sh": None,
     "shbe": None,
-    "tablegen": None,
-    "testgo": None,
+    "static": None,  # Added in Go 1.21
+    "tablegen": None,  # Removed in Go 1.19
+    "testgo": None,  # Removed in Go 1.19
     "timetzdata": None,
+    "tools": None,  # Added in Go 1.21
 }
diff --git a/go/tools/internal/stdlib_tags/stdlib_tags.go b/go/tools/internal/stdlib_tags/stdlib_tags.go
@@ -86,7 +86,7 @@ func walkFile(path string, tags map[string]struct{}) error {
 
 	scanner := bufio.NewScanner(file)
 	// The Go SDK contains some very long lines in vendored files (minified JS).
-	scanner.Buffer(make([]byte, 0, 128*1024), 1024*1024)
+	scanner.Buffer(make([]byte, 0, 128*1024), 2*1024*1024)
 	for scanner.Scan() {
 		line := scanner.Text()
 		if !isConstraint(line) {
@@ -102,6 +102,7 @@ func walkFile(path string, tags map[string]struct{}) error {
 	if err = scanner.Err(); err != nil {
 		return fmt.Errorf("%s: %w", path, err)
 	}
+
 	return nil
 }