-
Notifications
You must be signed in to change notification settings - Fork 694
Run update-deps.sh #549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run update-deps.sh #549
Conversation
|
Curious what's the best independent way to determine what this digest should be rules_docker/tests/docker/BUILD Lines 174 to 178 in 6d9fdf2
It's causing the failure here: |
|
@nlopezgi IIRC I built the digest target and also ran the push target and they both produced the same value. Then I took that value and put into the test. |
|
The digest is expected to be different if the base image is different. |
|
I pushed the necessary changes
Should the base image for these tests remain static? ie. pin the sha? |
|
We can create a new container_pull target named maybe distroless_base_test and pin to a specific version. |
|
Oh wait. distroless_base is created for testing purpose, so we can just pin this to a specific sha. Alternatively, there are two container_pull targets distroless_fixed_id and distroless_fixed_id_2 which we can use for test_digest_output1 and test_digest_output2. |
|
+1 to using distroless_fixed_id and distroless_fixed_id_2 for these tests |
This includes the commit GoogleContainerTools/distroless@f93e9b5 It adds the full text for various OSS licenses
|
rebased and re-ran the update deps script |
This includes the commit GoogleContainerTools/distroless@f93e9b5
It adds the full text for various OSS licenses