Skip to content

Conversation

@dprotaso
Copy link
Contributor

This includes the commit GoogleContainerTools/distroless@f93e9b5
It adds the full text for various OSS licenses

@dprotaso
Copy link
Contributor Author

Curious what's the best independent way to determine what this digest should be

file_test(
name = "test_digest_output2",
content = "sha256:acff18cc59851acc448c0f106ccefdd13907a91835d61b8b34f85a974a2e540a",
file = ":null_cmd_and_entrypoint_none.digest",
)

It's causing the failure here:
https://source.cloud.google.com/results/invocations/b915ecc0-2769-47bd-a26e-95a9a3b0bf37/targets/%2F%2Ftests%2Fdocker:test_digest_output2/log

@nlopezgi
Copy link
Contributor

nlopezgi commented Oct 17, 2018

hmm, @ash2k recently added this test (#445); could you comment on how you determined this value?

@ash2k
Copy link
Contributor

ash2k commented Oct 17, 2018

@nlopezgi IIRC I built the digest target and also ran the push target and they both produced the same value. Then I took that value and put into the test.

@ash2k
Copy link
Contributor

ash2k commented Oct 17, 2018

The digest is expected to be different if the base image is different.

@dprotaso
Copy link
Contributor Author

I pushed the necessary changes

The digest is expected to be different if the base image is different.

Should the base image for these tests remain static? ie. pin the sha?

@xingao267
Copy link
Contributor

We can create a new container_pull target named maybe distroless_base_test and pin to a specific version.

@xingao267
Copy link
Contributor

xingao267 commented Oct 17, 2018

Oh wait. distroless_base is created for testing purpose, so we can just pin this to a specific sha.

Alternatively, there are two container_pull targets distroless_fixed_id and distroless_fixed_id_2 which we can use for test_digest_output1 and test_digest_output2.

@nlopezgi
Copy link
Contributor

+1 to using distroless_fixed_id and distroless_fixed_id_2 for these tests

This includes the commit GoogleContainerTools/distroless@f93e9b5
It adds the full text for various OSS licenses
@dprotaso
Copy link
Contributor Author

rebased and re-ran the update deps script

@xingao267 xingao267 merged commit 39186e0 into bazelbuild:master Oct 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants