Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update rules scala to pick up maven to https change #1375

Merged
merged 2 commits into from
Jan 15, 2020

Conversation

nlopezgi
Copy link
Contributor

@nlopezgi nlopezgi commented Jan 15, 2020

Fixes #1373, subsumes #1374, also adding change to update pin to rules_scala. But in order for anything to pass CI now, we need to also update our references to maven central.

@nlopezgi
Copy link
Contributor Author

/gcbrun

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nlopezgi, smukherj1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nlopezgi nlopezgi merged commit 7dfb288 into bazelbuild:master Jan 15, 2020
@nlopezgi nlopezgi deleted the updateRulesScala branch January 15, 2020 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maven now requires HTTPS, Causing issues with javax servlet dependency
4 participants