Final fixes for mac using toolchains properly in py_binary target with bazel head #1191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlopezgi
force-pushed
the
testLastGree
branch
3 times, most recently
from
bc92baf to
e60f05f
Compare
nlopezgi
changed the title
nlopezgi
changed the title
|
/gcbrun |
nlopezgi
referenced
this pull request
Oct 8, 2019
…1173) The python toolchain we are registering for execution inside the container seems to be messing up with execution outside the container as documented here https://github.com/bazelbuild/rules_docker#known-issues-1. target_compatible_with should now be supported on all targets, so restricting our toolchain using target_compatible_with should make this error go away. See #1105
smukherj1
approved these changes
Oct 8, 2019
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nlopezgi, smukherj1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds logic to py_toolchains (copied over from cc_configure) to properly decide which cc-compiler-xx target will be produced by Bazel when running on mac.