-
Notifications
You must be signed in to change notification settings - Fork 693
support build stamp with docker_push #3
Comments
Or is that not what you want? |
Ok, blocked by: bazelbuild/bazel#1054 |
Similar / clarifying request: I'd like to be able to tag an image automatically using the git sha of the workspace. We use Make-style expansion isn't ideal, since that requires adding |
In other places we allow |
That might work. I implemented a hack (ixdy/bazel@3b29803) to do that a few months ago, and it's what the kubernetes bazel build is currently using, though it still feels pretty hacky (I got preoccupied with other things and didn't follow up on some review feedback, and now things have moved around a bit so I'd need to rebase my change.) The go rules got around waiting for Skylark support (bazelbuild/bazel#1054) by implementing stamping through reading the Since IIRC most of the actual docker image/layer-building implementation happens in python, I wonder if we could do something similar and have the info/version files passed through to the scripts on |
Is this fixed? |
|
I should be able to use a variable from my workspace status to tag a docker image when running docker_push.
The text was updated successfully, but these errors were encountered: