Replace apple_common.compilation_support.build_common_variables with rules_cc version#2862
Open
brentleyjones wants to merge 2 commits intomainfrom
Conversation
…h rules_cc version Needed for Bazel 9. PiperOrigin-RevId: 824908997 (cherry picked from commit 4b43d5d) Signed-off-by: Brentley Jones <github@brentleyjones.com>
adincebic
approved these changes
Jan 15, 2026
luispadron
approved these changes
Jan 15, 2026
mattrobmattrob
approved these changes
Jan 15, 2026
Collaborator
Author
|
rules_cc needs to adjust its visibility for this to land. |
Contributor
|
My in-progress branch with a bunch of commits from upstream: #2861 just got to this one needing to be applied, im getting: |
luispadron
added a commit
to luispadron/rules_cc
that referenced
this pull request
Jan 16, 2026
We need this to support Bazel 9+ (see: bazelbuild/rules_apple#2862)
Contributor
Member
|
Making this change would mean dropping support for Bazel < 9 (unless we cherry pick the required APIs into Bazel 7/8). Just want to make sure this is intended. To remain compatible, rules_apple can use |
copybara-service bot
pushed a commit
to bazelbuild/rules_cc
that referenced
this pull request
Jan 19, 2026
Copybara Import from #568 BEGIN_PUBLIC Mark `objc_compilation_support` as publicly visible (#568) We need this to support Bazel 9+ (see: bazelbuild/rules_apple#2862) Closes #568 END_PUBLIC COPYBARA_INTEGRATE_REVIEW=#568 from luispadron:patch-1 c6b6874 PiperOrigin-RevId: 857993845 Change-Id: I5dc48c54416d5c185627067be7cf8d61354d5343
luispadron
added a commit
to luispadron/rules_cc
that referenced
this pull request
Jan 20, 2026
We need this to support Bazel 9+ (see: bazelbuild/rules_apple#2862)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed for Bazel 9.
PiperOrigin-RevId: 824908997
(cherry picked from commit 4b43d5d)