Change databinding dependent lib artifact to a directory#228
Open
arunkumar9t2 wants to merge 1 commit intobazelbuild:mainfrom
Open
Change databinding dependent lib artifact to a directory#228arunkumar9t2 wants to merge 1 commit intobazelbuild:mainfrom
arunkumar9t2 wants to merge 1 commit intobazelbuild:mainfrom
Conversation
ahumesky
reviewed
Jun 14, 2024
| if path.startswith("../"): | ||
| path = path[3:] | ||
| dep_lib_artifact = ctx.actions.declare_file( | ||
| dep_lib_artifact = ctx.actions.declare_directory( |
Collaborator
There was a problem hiding this comment.
from an internal test, the _utils.copy_file(...) below at 127 fails with:
File "android_binary_internal.bzl", line 724, column 35, in _impl
return processing_pipeline.run(ctx, java_package, _PROCESSING_PIPELINE)
File "rules_android/rules/processing_pipeline.bzl", line 86, column 23, in _run
info = execute(ctx, **target_ctx)
File "rules_android/rules/android_binary_internal/impl.bzl", line 200, column 37, in _process_data_binding
value = data_binding.process(
File "rules_android/rules/data_binding.bzl", line 272, column 55, in _process
dep_lib_artifacts = _setup_dependent_lib_artifacts(ctx, output_dir, deps)
File "rules_android/rules/data_binding.bzl", line 130, column 33, in _setup_dependent_lib_artifacts
_utils.copy_file(ctx, artifact, dep_lib_artifact)
File "rules_android/rules/utils.bzl", line 214, column 13, in _copy_file
fail("Cannot use copy_file with directories")
Error in fail: Cannot use copy_file with directories
did this work in your local testing?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependent lib artifact is supposed to be a directory but was registered as a
file. This is an error in Bazel 7 due to--incompatible_disallow_unsound_directory_outputswhich will be enforced in Bazel 8.Ref