Add Remote Asset API #112
Add Remote Asset API #112
Conversation
googlebot
added
the
cla: yes
|
@jmillikin-stripe @EricBurnett please have a look. Alternatively we fold it all in the remote_execution.proto. |
The final proto is based on the [Fetch API design document](https://docs.google.com/document/d/10ari9WtTTSv9bqB_UU-oe2gBtaAA7HyQgkpP-RFP80c) and updates in bazelbuild/proposals#160. * build/bazel/remote/asset/v1/BUILD Generate the various language outputs. * build/bazel/remote/asset/v1/qualifiers.md Registry for well known qualifiers. * build/bazel/remote/asset/v1/remote_asset.pb.go Generated proto output for Go. * build/bazel/remote/asset/v1/remote_asset.proto The actual Remote Asset API * hooks/pre-commit Hook in the build for the new API. Co-Authored-By: Eric Burnett <ericburnett@gmail.com> Co-authored-by: John Millikin <jmillikin@stripe.com>
sstriker
force-pushed
the
remote-fetch-api
branch
from
df7307e
to
d0bec6c
Compare
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
googlebot
added
cla: no
sstriker
force-pushed
the
remote-fetch-api
branch
from
d0bec6c
to
32f1ba1
Compare
sstriker
requested review from
agoulti,
bergsieker,
buchgr,
ola-rozenfeld and
ulfjack
as code owners
|
@googlebot I consent |
|
@googlebot I consent |
|
Huge congrats @jmillikin-stripe @sstriker @EricBurnett for shipping the API! |
|
FYI: While implementing this in Bazel I discovered that some of the quotes in the comment blocks have been replaced with Unicode versions. This makes ASCII-only consumers, including the Bazel CI runners, very unhappy. I'll fix this for Bazel in the initial vendor. Can someone with a commit bit fix it in this repo, so other clients don't hit the same problem? Example error (from https://storage.googleapis.com/bazel-untrusted-buildkite-artifacts/beb93ad4-5b4f-43c0-925c-2a6a2b6d73d7/src/test/shell/bazel/bazel_bootstrap_distfile_test/attempt_1.log): |
Closes #10818. Signed-off-by: Philipp Wollermann <philwo@google.com>
|
@jmillikin-stripe Sure, I can merge a PR that fixes that. |
This is the Bazel client implementation of bazelbuild/proposals#160. It allows downloading of external dependencies to be delegated to a remote service. TODOs: - [x] Once bazelbuild/remote-apis#112 is merged, the vendored copy of `bazelbuild/remote-apis` should be updated. I've used a [WIP] placeholder for now. - [x] If the general approach looks reasonable then I'll add tests. Currently I've been testing with an in-house implementation of the downloader server. R: @buchgr @dslomov CC: @EricBurnett @sstriker @ulfjack Closes #10622. PiperOrigin-RevId: 300116716
This is the Bazel client implementation of bazelbuild/proposals#160. It allows downloading of external dependencies to be delegated to a remote service. TODOs: - [x] Once bazelbuild/remote-apis#112 is merged, the vendored copy of `bazelbuild/remote-apis` should be updated. I've used a [WIP] placeholder for now. - [x] If the general approach looks reasonable then I'll add tests. Currently I've been testing with an in-house implementation of the downloader server. R: @buchgr @dslomov CC: @EricBurnett @sstriker @ulfjack Closes #10622. PiperOrigin-RevId: 300116716
Based on the design document
and updates in bazelbuild/proposals#160.