Fix merging of runfiles library runfiles #557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Runfiles should not be merged as files, unless promoting data dependencies.
gregestren
approved these changes
Feb 20, 2025
|
These are upstream issues in rules_lint and rules_rust. I will send fixes. |
fmeum
added a commit
to fmeum/rules_lint
that referenced
this pull request
Feb 24, 2025
As `@bazel_tools//tools/bash/runfiles` is now an alias to `@rules_shell//shell/runfiles` with Bazel@HEAD, consumers must properly merge all its runfiles rather than assuming that the `sh_library` target just consists of a single file. Work towards bazelbuild/examples#557 (comment)
This was referenced Feb 24, 2025
github-merge-queue bot
pushed a commit
to bazelbuild/rules_rust
that referenced
this pull request
Feb 24, 2025
As `@bazel_tools//tools/bash/runfiles` is now an alias to `@rules_shell//shell/runfiles` with Bazel@HEAD, consumers must properly merge all its runfiles rather than assuming that the `sh_library` target just consists of a single file. Work towards bazelbuild/examples#557 (comment)
github-merge-queue bot
pushed a commit
to bazelbuild/rules_rust
that referenced
this pull request
Feb 24, 2025
As `@bazel_tools//tools/bash/runfiles` is now an alias to `@rules_shell//shell/runfiles` with Bazel@HEAD, consumers must properly merge all its runfiles rather than assuming that the `sh_library` target just consists of a single file. Work towards bazelbuild/examples#557 (comment)
github-merge-queue bot
pushed a commit
to bazelbuild/rules_rust
that referenced
this pull request
Feb 24, 2025
As `@bazel_tools//tools/bash/runfiles` is now an alias to `@rules_shell//shell/runfiles` with Bazel@HEAD, consumers must properly merge all its runfiles rather than assuming that the `sh_library` target just consists of a single file. Work towards bazelbuild/examples#557 (comment)
github-merge-queue bot
pushed a commit
to bazelbuild/rules_rust
that referenced
this pull request
Feb 24, 2025
As `@bazel_tools//tools/bash/runfiles` is now an alias to `@rules_shell//shell/runfiles` with Bazel@HEAD, consumers must properly merge all its runfiles rather than assuming that the `sh_library` target just consists of a single file. Work towards bazelbuild/examples#557 (comment)
github-merge-queue bot
pushed a commit
to bazelbuild/rules_rust
that referenced
this pull request
Feb 24, 2025
As `@bazel_tools//tools/bash/runfiles` is now an alias to `@rules_shell//shell/runfiles` with Bazel@HEAD, consumers must properly merge all its runfiles rather than assuming that the `sh_library` target just consists of a single file. Work towards bazelbuild/examples#557 (comment)
github-merge-queue bot
pushed a commit
to bazelbuild/rules_rust
that referenced
this pull request
Feb 24, 2025
As `@bazel_tools//tools/bash/runfiles` is now an alias to `@rules_shell//shell/runfiles` with Bazel@HEAD, consumers must properly merge all its runfiles rather than assuming that the `sh_library` target just consists of a single file. Work towards bazelbuild/examples#557 (comment)
github-merge-queue bot
pushed a commit
to bazelbuild/rules_rust
that referenced
this pull request
Feb 24, 2025
As `@bazel_tools//tools/bash/runfiles` is now an alias to `@rules_shell//shell/runfiles` with Bazel@HEAD, consumers must properly merge all its runfiles rather than assuming that the `sh_library` target just consists of a single file. Work towards bazelbuild/examples#557 (comment)
github-merge-queue bot
pushed a commit
to bazelbuild/rules_rust
that referenced
this pull request
Feb 24, 2025
As `@bazel_tools//tools/bash/runfiles` is now an alias to `@rules_shell//shell/runfiles` with Bazel@HEAD, consumers must properly merge all its runfiles rather than assuming that the `sh_library` target just consists of a single file. Work towards bazelbuild/examples#557 (comment)
alexeagle
pushed a commit
to aspect-build/rules_lint
that referenced
this pull request
Mar 4, 2025
As `@bazel_tools//tools/bash/runfiles` is now an alias to `@rules_shell//shell/runfiles` with Bazel@HEAD, consumers must properly merge all its runfiles rather than assuming that the `sh_library` target just consists of a single file. Work towards bazelbuild/examples#557 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runfiles should not be merged as files, unless promoting data dependencies.
Fixes #556