chore: update to latest rules_nodejs #1207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeagle
requested review from
vladmos,
pmbethe09 and
larsrc-google
as code owners
|
There are build failures for the PR, could you please take a look at them? |
alexeagle
force-pushed
the
master
branch
2 times, most recently
from
32c09b9 to
bc087d7
Compare
|
Green now. I also added an optional pre-commit setup so CI doesn't yell at me about buildifier. (It doesn't even print which files had format/lint warnings...) |
Simplify by writing the buildozer program in JavaScript rather than TypeScript so we don't need any devDependencies
|
Thanks! Do I understand correctly that the precommit hook only those who explicitly installed |
|
Correct, all git commit hook libraries have reached consensus that developers should opt-in. No magic going on. The only thing maybe worth improving here is for a failing CI run to recommend the developer run |
vladmos
approved these changes
Oct 10, 2023
apattidb
pushed a commit
to databricks/buildtools
that referenced
this pull request
May 10, 2024
Simplify by writing the buildozer program in JavaScript rather than TypeScript so we don't need any devDependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify by writing the buildozer program in JavaScript rather than TypeScript so we don't need any devDependencies