Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default java toolchain target #8569

Closed

Conversation

iirina
Copy link
Contributor

@iirina iirina commented Jun 6, 2019

The previous javac version used by the default_java_toolchain in Bazel had a non-standard modification to default to the Java 8 language level, which wasn't carried forward to 11. Adding default values for {source,target}_version in the default_java_toolchain to keep Bazel backwards compatibility. Fixes #8539.

@iirina iirina requested a review from hlopko June 6, 2019 08:06
Copy link
Member

@hlopko hlopko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bazel-io bazel-io closed this in 6ef6d87 Jun 6, 2019
laurentlb pushed a commit that referenced this pull request Jun 6, 2019
The previous javac version used by the default_java_toolchain in Bazel had a non-standard modification to default to the Java 8 language level, which wasn't carried forward to 11. Adding default values for {source,target}_version in the default_java_toolchain to keep Bazel backwards compatibility.

Fixes #8539.

Closes #8569.

PiperOrigin-RevId: 251848351
laurentlb pushed a commit that referenced this pull request Jun 7, 2019
The previous javac version used by the default_java_toolchain in Bazel had a non-standard modification to default to the Java 8 language level, which wasn't carried forward to 11. Adding default values for {source,target}_version in the default_java_toolchain to keep Bazel backwards compatibility.

Fixes #8539.

Closes #8569.

PiperOrigin-RevId: 251848351
irengrig pushed a commit to irengrig/bazel that referenced this pull request Jun 18, 2019
The previous javac version used by the default_java_toolchain in Bazel had a non-standard modification to default to the Java 8 language level, which wasn't carried forward to 11. Adding default values for {source,target}_version in the default_java_toolchain to keep Bazel backwards compatibility.

Fixes bazelbuild#8539.

Closes bazelbuild#8569.

PiperOrigin-RevId: 251848351
irengrig pushed a commit to irengrig/bazel that referenced this pull request Jul 15, 2019
The previous javac version used by the default_java_toolchain in Bazel had a non-standard modification to default to the Java 8 language level, which wasn't carried forward to 11. Adding default values for {source,target}_version in the default_java_toolchain to keep Bazel backwards compatibility.

Fixes bazelbuild#8539.

Closes bazelbuild#8569.

PiperOrigin-RevId: 251848351
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Java runtime mismatch (JDK 11 instead of JDK 8) on Bazel@HEAD
3 participants