Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows, build-runfiles: Implement build-runfiles for Windows #6024

Closed

Conversation

meteorcloudy
Copy link
Member

Working towards: #5807

@laszlocsomor

Working towards: bazelbuild#5807

Change-Id: Iae10ff439bb3e8513c44ebfc4c174409623991d9
src/main/tools/build-runfiles-windows.cc Outdated Show resolved Hide resolved
src/main/tools/build-runfiles-windows.cc Show resolved Hide resolved
src/main/tools/build-runfiles-windows.cc Outdated Show resolved Hide resolved
src/main/tools/build-runfiles-windows.cc Outdated Show resolved Hide resolved
src/main/tools/build-runfiles-windows.cc Outdated Show resolved Hide resolved
src/test/shell/integration/runfiles_test.sh Outdated Show resolved Hide resolved
src/test/shell/integration/runfiles_test.sh Outdated Show resolved Hide resolved
src/test/shell/integration/runfiles_test.sh Outdated Show resolved Hide resolved
src/test/shell/integration/runfiles_test.sh Outdated Show resolved Hide resolved
src/test/shell/integration/runfiles_test.sh Outdated Show resolved Hide resolved
Change-Id: If02139f98264ba9d282d29c405cb7eaedf4797c0
Copy link
Member Author

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the throughout review! Please take a look again~

src/main/tools/build-runfiles-windows.cc Outdated Show resolved Hide resolved
src/main/tools/build-runfiles-windows.cc Show resolved Hide resolved
src/main/tools/build-runfiles-windows.cc Outdated Show resolved Hide resolved
src/main/tools/build-runfiles-windows.cc Outdated Show resolved Hide resolved
src/main/tools/build-runfiles-windows.cc Outdated Show resolved Hide resolved
src/test/shell/integration/runfiles_test.sh Outdated Show resolved Hide resolved
src/test/shell/integration/runfiles_test.sh Outdated Show resolved Hide resolved
src/test/shell/integration/runfiles_test.sh Outdated Show resolved Hide resolved
src/test/shell/integration/runfiles_test.sh Outdated Show resolved Hide resolved
src/test/shell/integration/runfiles_test.sh Outdated Show resolved Hide resolved
src/main/tools/build-runfiles-windows.cc Show resolved Hide resolved
src/main/tools/build-runfiles-windows.cc Show resolved Hide resolved
src/main/tools/build-runfiles-windows.cc Outdated Show resolved Hide resolved
src/main/tools/build-runfiles-windows.cc Outdated Show resolved Hide resolved
src/main/tools/build-runfiles-windows.cc Outdated Show resolved Hide resolved
src/test/shell/integration/runfiles_test.sh Outdated Show resolved Hide resolved
src/test/shell/integration/runfiles_test.sh Outdated Show resolved Hide resolved
Change-Id: I2e1fb56f7686872f5e7d4724c93c1ad2e6e02311
Copy link
Member Author

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

src/main/tools/build-runfiles-windows.cc Outdated Show resolved Hide resolved
src/main/tools/build-runfiles-windows.cc Show resolved Hide resolved
src/main/tools/build-runfiles-windows.cc Outdated Show resolved Hide resolved
src/main/tools/build-runfiles-windows.cc Show resolved Hide resolved
src/test/shell/integration/runfiles_test.sh Outdated Show resolved Hide resolved
src/test/shell/integration/runfiles_test.sh Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants