Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

windows: GetOutputRoot() returns GetHomeDir() #5039

Closed
wants to merge 1 commit into from
Closed

windows: GetOutputRoot() returns GetHomeDir() #5039

wants to merge 1 commit into from

Conversation

laszlocsomor
Copy link
Contributor

This is an immediate fix for a very nasty bug:
#5038

Change-Id: I5e4f9fa13e5ac785514bc0dc4ce6cba9a88f33bb

@laszlocsomor
windows: GetOutputRoot() returns GetHomeDir()
38af304 
This is an immediate fix for a very nasty bug:
bazelbuild#5038

Change-Id: I5e4f9fa13e5ac785514bc0dc4ce6cba9a88f33bb
@laszlocsomor
Copy link
Contributor Author

/cc @jasharpe

meteorcloudy
meteorcloudy approved these changes Apr 17, 2018
View reviewed changes
Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bazel-io bazel-io closed this in f083e76 Apr 18, 2018
@laszlocsomor laszlocsomor deleted the tmpdir-homedir branch April 18, 2018 07:46
meteorcloudy pushed a commit that referenced this pull request Apr 19, 2018
@laszlocsomor @meteorcloudy
windows: GetOutputRoot() returns GetHomeDir()
4b9e096 
This is an immediate fix for a very nasty bug:
#5038

Change-Id: I5e4f9fa13e5ac785514bc0dc4ce6cba9a88f33bb

Closes #5039.

Change-Id: I5e4f9fa13e5ac785514bc0dc4ce6cba9a88f33bb
PiperOrigin-RevId: 193315571
meteorcloudy pushed a commit that referenced this pull request Apr 24, 2018
@laszlocsomor @meteorcloudy
windows: GetOutputRoot() returns GetHomeDir()
b088001 
This is an immediate fix for a very nasty bug:
#5038

Change-Id: I5e4f9fa13e5ac785514bc0dc4ce6cba9a88f33bb

Closes #5039.

Change-Id: I5e4f9fa13e5ac785514bc0dc4ce6cba9a88f33bb
PiperOrigin-RevId: 193315571
meteorcloudy pushed a commit that referenced this pull request Apr 26, 2018
@laszlocsomor @meteorcloudy
windows: GetOutputRoot() returns GetHomeDir()
4d269d7 
This is an immediate fix for a very nasty bug:
#5038

Change-Id: I5e4f9fa13e5ac785514bc0dc4ce6cba9a88f33bb

Closes #5039.

Change-Id: I5e4f9fa13e5ac785514bc0dc4ce6cba9a88f33bb
PiperOrigin-RevId: 193315571
meteorcloudy pushed a commit that referenced this pull request Apr 26, 2018
@laszlocsomor @meteorcloudy
windows: GetOutputRoot() returns GetHomeDir()
a18b11e 
This is an immediate fix for a very nasty bug:
#5038

Change-Id: I5e4f9fa13e5ac785514bc0dc4ce6cba9a88f33bb

Closes #5039.

Change-Id: I5e4f9fa13e5ac785514bc0dc4ce6cba9a88f33bb
PiperOrigin-RevId: 193315571
meteorcloudy pushed a commit that referenced this pull request May 7, 2018
@laszlocsomor @meteorcloudy
windows: GetOutputRoot() returns GetHomeDir()
8812669 
This is an immediate fix for a very nasty bug:
#5038

Change-Id: I5e4f9fa13e5ac785514bc0dc4ce6cba9a88f33bb

Closes #5039.

Change-Id: I5e4f9fa13e5ac785514bc0dc4ce6cba9a88f33bb
PiperOrigin-RevId: 193315571
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meteorcloudy meteorcloudy meteorcloudy approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laszlocsomor @meteorcloudy @googlebot