JavaBuilder changes for unused dependencies checking - #30807
Open
JonathanPerry651 wants to merge 1 commit into
Open
JavaBuilder changes for unused dependencies checking#30807JonathanPerry651 wants to merge 1 commit into
JonathanPerry651 wants to merge 1 commit into
Conversation
github-actions
Bot
added
team-Rules-Java
This was referenced Aug 20, 2026
|
✅ Bazel docs preview is ready! Preview URL: https://bazel-pr-30807.mintlify.app/ Updated for |
hvadehra
approved these changes
Aug 20, 2026
katre
reviewed
Aug 20, 2026
| @@ -204,6 +204,57 @@ public void postAttribute(Env<AttrContext> env) { | |||
| public void finish() { | |||
| implicitDependencyExtractor.accumulate(context, checkingTreeScanner.getSeenClasses()); | |||
|
|
|||
| if (dependencyModule.getUnusedDeps() != UnusedDepsMode.OFF) { | |||
| Optional<String> targetLabel = | |||
Collaborator
There was a problem hiding this comment.
Small nit: Since you're only using this Optional to call isPresent(), why use it?
I'd propose instead moving all of this code into a helper method called checkUnusedDeps, and then in that, if dependencyModule.getTargetLabel() is false, return early. It will reduce the indentation on this code and make it a bit easier to scan the entire finish method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request contains the JavaBuilder-side changes for unused dependencies checking, splitting the functionality as requested by @hvadehra in #29770.