DEBUG: diagnose flaky memory-pressure RRCC test on Windows - #30755
Closed
fmeum wants to merge 3 commits into
Closed
Conversation
Not for merge. Adds ground-truth logging for fetch restarts and state drops, dumps per-attempt diagnostics from the test, and trims the CI config down to repeated Windows runs of the flaky test only.
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Debug only, do not merge. Opened to collect Windows CI data on the flakiness of
testMemoryPressureRestartDuringCachedFetch.Description
Three temporary changes:
RepositoryFetchFunctionlogsDEBUG_RESTARTto the server log whenever a fetch is restarted after a memory-pressure compute state drop, andHighWaterMarkLimiterlogs every singleDEBUG_DROP(the existing statements are rate limited to one per 10s). The test can only observe restarts through the progress bar today, which is transient and may never be rendered, so a missing message in stderr does not tell us whether the fetch was actually interrupted..bazelci/presubmit.ymlis trimmed down to a single Windows task that runs only this test, 6 times, so that one CI run yields 30 samples.Motivation
The test is flaky on Windows on master:
Build API Changes
No
Checklist
Release Notes
RELNOTES: None