Add --experimental_max_repeated_lost_inputs to make the action-rewinding lost-input limit configurable#30164
Open
eaugene wants to merge 1 commit into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
eaugene
force-pushed
the
configurable-lost-input-rewind-limit
branch
from
f9dd081 to
956c5ea
Compare
…t-input limit configurable Action rewinding gives up -- failing the build with LOST_INPUT_TOO_MANY_TIMES / LOST_OUTPUT_TOO_MANY_TIMES -- once the same action loses the same input/output more than a hardcoded MAX_REPEATED_LOST_INPUTS = 20 times. Under build-without-the-bytes, repeated losses come from remote-cache eviction of intermediate blobs, and the right ceiling is deployment-dependent: sites with aggressive eviction hit 20 and fail spuriously, while others would rather fail fast than spend 20 rewinds masking an unhealthy cache. Tuning it currently requires patching Bazel. This adds --experimental_max_repeated_lost_inputs (default 20, behavior- preserving), threaded through BuildRequestOptions -> SkyframeActionExecutor -> ActionRewindStrategy the same way as --rewind_lost_inputs. It governs both the lost-input and lost-top-level-output give-up checks. Tested by a new RewindingTest case (limit=2 => give up at attempt 3) alongside the unchanged default-limit test.
eaugene
force-pushed
the
configurable-lost-input-rewind-limit
branch
from
956c5ea to
7ef8397
Compare
github-actions
Bot
added
team-Core
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Action rewinding gives up — failing the build with
LOST_INPUT_TOO_MANY_TIMES/LOST_OUTPUT_TOO_MANY_TIMES— once the same action loses the same input/output more than a hardcodedMAX_REPEATED_LOST_INPUTS = 20times (ActionRewindStrategy).Under Build-without-the-Bytes, these repeated losses are typically caused by remote-cache eviction of intermediate blobs. The right ceiling is deployment-dependent: installations with aggressive eviction hit 20 and fail spuriously, while others would rather fail fast than spend 20 rewinds masking an unhealthy cache. Today the only way to change it is to patch Bazel.
Change
Adds
--experimental_max_repeated_lost_inputs(default20, behavior-preserving), threaded throughBuildRequestOptions→SkyframeActionExecutor(cached per build inprepareForExecution, exposed viamaxRepeatedLostInputs()) →ActionRewindStrategy, mirroring the existing--rewind_lost_inputswiring. It governs both the lost-input and lost-top-level-output give-up checks. TheMAX_REPEATED_LOST_INPUTSconstant is retained as the default and test anchor.