Build builtins_bzl.zip with a Starlark rule#30123
Open
dzbarsky wants to merge 1 commit into
Open
Conversation
dzbarsky
force-pushed
the
codex/simplify-builtins-zip
branch
from
ec9bcf1 to
a477a52
Compare
github-actions
Bot
added
the
awaiting-review
fmeum
reviewed
Jul 3, 2026
fmeum
reviewed
Jul 3, 2026
fmeum
approved these changes
Jul 3, 2026
github-actions
Bot
added
the
community-reviewed
dzbarsky
force-pushed
the
codex/simplify-builtins-zip
branch
from
a477a52 to
bac83ca
Compare
Contributor
Author
|
Need to remove Line 1 in 9ae0848 |
Replace the shell genrule with a builtins_zip rule that invokes the declared zipper tool. Keep the rule in //src so the builtins source glob remains simple. Make _zipper a private default attribute and use Args.add_all to map builtins sources into the archive.
dzbarsky
force-pushed
the
codex/simplify-builtins-zip
branch
from
bac83ca to
30047a3
Compare
fmeum
approved these changes
Jul 4, 2026
meisterT
approved these changes
Jul 6, 2026
meisterT
added
awaiting-PR-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the
builtins_bzl.zipshellgenrulewith a dedicatedbuiltins_zipStarlark rule.This focused change is extracted from #30121 for independent review.
Motivation
The existing
genrulediscovers its source root with shell commands and invokeszip_builtins.sh, which depends on shell path handling.builtins_zipdeclares the zipper tool and source inputs directly, preserving thebuiltins_bzl/<relative path>archive layout without shell path handling.Build API Changes
No.
Validation
buildifier -mode=check src/main/starlark/builtins_bzl/BUILD src/builtins_zip.bzlbazel build --jobs=2 //src/main/starlark/builtins_bzl:builtins_bzl_zipunzip -Z1output to the sorted**/*.bzlsource list; entries matched exactlybazel aqueryconfirmed_zipperis an execution-configured declared tool and all archive mappings are correctRelease Notes
RELNOTES: None