[9.1.0] Reduce Merkle tree footprint by lazily converting to Paths (https:/…#28831
Open
iancha1992 wants to merge 1 commit intobazelbuild:release-9.1.0from
Open
[9.1.0] Reduce Merkle tree footprint by lazily converting to Paths (https:/…#28831iancha1992 wants to merge 1 commit intobazelbuild:release-9.1.0from
Paths (https:/…#28831iancha1992 wants to merge 1 commit intobazelbuild:release-9.1.0from
Conversation
…ild#28737) `Path`s of `ActionInput`s are typically not retained, which means that keeping them in memory as part of a Merkle tree is wasteful. Instead, retain the inputs and lazily convert to `Path` when uploading using the `ArtifactPathResolver` anyway retained by `SpawnExecutionContext`. Work towards bazelbuild#20478 Work towards bazelbuild#28734 No - [ ] I have added tests for the new use cases (if any). - [ ] I have updated the documentation (if applicable). RELNOTES: None Closes bazelbuild#28737. PiperOrigin-RevId: 876039610 Change-Id: Id4af6af2daf7ef72e8a8e3da35f00e2dccd81bd0
iancha1992
added
team-Remote-Exec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…/github.com//pull/28737)
Paths ofActionInputs are typically not retained, which means that keeping them in memory as part of a Merkle tree is wasteful. Instead, retain the inputs and lazily convert toPathwhen uploading using theArtifactPathResolveranyway retained bySpawnExecutionContext.Work towards #20478
Work towards #28734
No
RELNOTES: None
Closes #28737.
PiperOrigin-RevId: 876039610
Change-Id: Id4af6af2daf7ef72e8a8e3da35f00e2dccd81bd0
Description
Motivation
Build API Changes
No
Checklist
Release Notes
RELNOTES: None
Commit 21ac6c1