[9.0.1] Add a new optional param to fail() to allow pretty-printing user erro…#28817
Open
iancha1992 wants to merge 1 commit intobazelbuild:release-9.0.1from
Open
[9.0.1] Add a new optional param to fail() to allow pretty-printing user erro…#28817iancha1992 wants to merge 1 commit intobazelbuild:release-9.0.1from
iancha1992 wants to merge 1 commit intobazelbuild:release-9.0.1from
Conversation
…rs without a stack trace. This allows a new fail(stack_trace = False, 'Message') which will not include a stack trace. This allows an intentional failure that is user facing to be a bit more user friendly since they're unlikely to want to see the stack trace. A flag --force_eval_stack_trace can be used to unconditionally include the stack trace for debugging. RELNOTES: Added an optional parameter to allow eliding the stack trace when calling fail(). PiperOrigin-RevId: 834908566 Change-Id: Ia7fd1673ec90e068b1a23578bd1094c662b94312
iancha1992
added
awaiting-review
iancha1992
referenced
this pull request
Feb 26, 2026
…rs without a stack trace. This allows a new fail(stack_trace = False, 'Message') which will not include a stack trace. This allows an intentional failure that is user facing to be a bit more user friendly since they're unlikely to want to see the stack trace. A flag --force_eval_stack_trace can be used to unconditionally include the stack trace for debugging. RELNOTES: Added an optional parameter to allow eliding the stack trace when calling fail(). PiperOrigin-RevId: 834908566 Change-Id: Ia7fd1673ec90e068b1a23578bd1094c662b94312
Member
Author
|
@brandjon won't be able to approve this PR until March 2nd. So added you as reviewers @Wyverald @meteorcloudy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…rs without a stack trace.
This allows a new fail(stack_trace = False, 'Message') which will not include a stack trace. This allows an intentional failure that is user facing to be a bit more user friendly since they're unlikely to want to see the stack trace. A flag --force_eval_stack_trace can be used to unconditionally include the stack trace for debugging.
RELNOTES:
Added an optional parameter to allow eliding the stack trace when calling fail(). PiperOrigin-RevId: 834908566
Change-Id: Ia7fd1673ec90e068b1a23578bd1094c662b94312
Description
Motivation
Build API Changes
No
Checklist
Release Notes
RELNOTES: None
Commit d787b3b