Allow toolchain features to mark paths for path mapping#28794
Draft
fmeum wants to merge 2 commits intobazelbuild:masterfrom
Draft
Allow toolchain features to mark paths for path mapping#28794fmeum wants to merge 2 commits intobazelbuild:masterfrom
fmeum wants to merge 2 commits intobazelbuild:masterfrom
Conversation
Switch from abstract classes to interfaces to enable widespread migration to records and delete a bunch of dead code.
github-actions
bot
added
team-Rules-CPP
fmeum
changed the title
2 tasks
Collaborator
Author
|
@bazel-io fork 9.1.0 |
Collaborator
Author
|
The corresponding rules_cc PR is bazelbuild/rules_cc#609. When the current PR has been merged, I will amend the rules_cc PR with a bazel_features check for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
rules_cc's rule-based toolchain can now inject paths into toolchain features that will be recognized as exec paths and path mapped appropriately by wrapping them in
${path:<the path>}.Motivation
Work towards cerisier/toolchains_llvm_bootstrapped#335
Build API Changes
No
Checklist
Release Notes
RELNOTES: None