Fix cross-platform launcher_maker actions#28746
Closed
fmeum wants to merge 1 commit intobazelbuild:masterfrom
Closed
Fix cross-platform launcher_maker actions#28746fmeum wants to merge 1 commit intobazelbuild:masterfrom
launcher_maker actions#28746fmeum wants to merge 1 commit intobazelbuild:masterfrom
Conversation
The `launcher_maker` binary should be built for the exec platform when using the from-source toolchain (e.g., when cross-compiling from Unix to Windows).
github-actions
bot
added
the
awaiting-review
Collaborator
Author
|
@bazel-io fork 9.1.0 |
meteorcloudy
approved these changes
Feb 23, 2026
meteorcloudy
added
awaiting-PR-merge
github-actions
bot
removed
the
awaiting-PR-merge
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Feb 24, 2026
### Description The `launcher_maker` binary should be built for the exec platform when using the from-source toolchain. ### Motivation Fixing Unix-to-Windows cross-platform builds. ### Build API Changes No ### Checklist - [ ] I have added tests for the new use cases (if any). - [ ] I have updated the documentation (if applicable). ### Release Notes RELNOTES: None Closes bazelbuild#28746. PiperOrigin-RevId: 874445666 Change-Id: I4cfe6133a442432b04bd701afe253b6cf2b49250
2 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 24, 2026
### Description The `launcher_maker` binary should be built for the exec platform when using the from-source toolchain. ### Motivation Fixing Unix-to-Windows cross-platform builds. ### Build API Changes No ### Checklist - [ ] I have added tests for the new use cases (if any). - [ ] I have updated the documentation (if applicable). ### Release Notes RELNOTES: None Closes #28746. PiperOrigin-RevId: 874445666 Change-Id: I4cfe6133a442432b04bd701afe253b6cf2b49250 Commit aabad1a Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
launcher_makerbinary should be built for the exec platform when using the from-source toolchain.Motivation
Fixing Unix-to-Windows cross-platform builds.
Build API Changes
No
Checklist
Release Notes
RELNOTES: None