Reduce Merkle tree footprint by using an ImmutableSortedMap#28735
Open
fmeum wants to merge 4 commits intobazelbuild:masterfrom
Open
Reduce Merkle tree footprint by using an ImmutableSortedMap#28735fmeum wants to merge 4 commits intobazelbuild:masterfrom
ImmutableSortedMap#28735fmeum wants to merge 4 commits intobazelbuild:masterfrom
Conversation
github-actions
bot
added
team-Remote-Exec
Collaborator
Author
|
@bazel-io fork 9.1.0 |
fmeum
changed the title
ImmutableSortedMapImmutableSortedMap
fmeum
force-pushed
the
optimize-merkle-tree-size
branch
5 times, most recently
from
fc6433d to
f9b3356
Compare
fmeum
force-pushed
the
optimize-merkle-tree-size
branch
from
f9b3356 to
1e47e48
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
An
ImmutableSortedMapuses less memory than anImmutableMapand access performance is masked by network I/O anyway. A secondary benefit is that memory usage becomes deterministic.This includes pulling in a memory optimization to protobuf via a patch that is already active in the google3 version, thereby reducing the instance size of
Digestto 32 bytes.Motivation
Work towards #20478
Work towards #28734
Build API Changes
No
Checklist
Release Notes
RELNOTES: None