Update rules_cc to 0.2.17

[fmeum]

Description

Updates rules_cc to 0.2.17 in MODULE.bazel and MODULE.tools.

Motivation

Build API Changes

No

Checklist

• I have added tests for the new use cases (if any).
• I have updated the documentation (if applicable).

Release Notes

RELNOTES: None

[fmeum]

@trybka @pzembrod rules_cc v0.2.17 causes some of Bazel's tests to fail, but it's not obvious to me what the root cause is.

@dzbarsky FYI, this issue is unrelated to your attempted blake3 update.

[iancha1992]

@trybka @pzembrod rules_cc v0.2.17 causes some of Bazel's tests to fail, but it's not obvious to me what the root cause is.

@dzbarsky FYI, this issue is unrelated to your attempted blake3 update.

Hi @trybka @pzembrod. Any update on this? We're planning to get 9.0.1rc1 on Wednesday.

[trybka]

@c-mita @hvadehra

[hvadehra]

The logs indicate this was likely caused by bazelbuild/rules_cc@6402462 and the problem with the mocks in Bazel is that

bazel/src/test/java/com/google/devtools/build/lib/analysis/mock/BUILD

Lines 25 to 27 in b811c95

	"@rules_cc//cc:srcs",
	"@rules_cc//cc/common:srcs",
	"@rules_cc//cc/toolchains:srcs",

does not include srcs from https://github.com/bazelbuild/rules_cc/tree/main/cc/toolchains/impl

This will need to be fixed in rules_cc - https://github.com/bazelbuild/rules_cc/blob/38517fb1eb1333517b5a4e9bbaa169027b7a5988/cc/toolchains/BUILD#L43 should include srcs from all sub packages.

[trybka]

@hvadehra thanks for the analysis!

What is the fix for catching something like that in the future? Presumably porting many of the tests that validate cc behavior from Java->Starlark?

I think there are other java tests that just use things in rules_cc because they were convenient target types (e.g. for generic analysis tests) -- presumably those could either be migrated to use other rules?

Would it be possible to setup a bazelbuild CI with rules_cc at TOT, or even better run bazelbuild tests with rules_cc PRs?

[pzembrod]

I believe this is caused by a gap in MockCcSupport.java. I'm working on it.

[pzembrod]

Under @hvadehra's guidance this turned into a one-line fix in src/test/java/com/google/devtools/build/lib/packages/util/BazelMockCcSupport.java.

@fmeum can you rebase your PR and retrigger the checks?

[fmeum]

@pzembrod done

[pzembrod]

@pzembrod done

Thanks!