Add integration tests for GrpcRemoteDownloader
#28490
Open
+685
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This required adding support for the Remote Asset API to the remote worker used in tests.
github-actions
bot
added
team-Remote-Exec
Collaborator
Author
|
@bazel-io fork 9.1.0 |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds integration tests for the GrpcRemoteDownloader and implements the required Remote Asset API Fetch service in the test worker. The implementation is solid, but I've found a couple of high-severity issues in the new FetchServer: a potential memory leak due to an unbounded cache and an integer overflow bug in timeout handling. My review includes suggestions to fix these issues.
src/tools/remote/src/main/java/com/google/devtools/build/remote/worker/FetchServer.java
Show resolved
Hide resolved
src/tools/remote/src/main/java/com/google/devtools/build/remote/worker/FetchServer.java
Show resolved
Hide resolved
src/tools/remote/src/main/java/com/google/devtools/build/remote/worker/FetchServer.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This required adding support for the Remote Asset API to the remote worker used in tests.