Skip to content

Allow repo rules to define previously reserved attributes #28453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
michaelm-openai wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow repo rules to define previously reserved attributes #28453

michaelm-openai wants to merge 1 commit into from
+55 −9

Conversation

@michaelm-openai
Copy link

@michaelm-openai michaelm-openai commented Jan 27, 2026

Fixes #28450

@github-actions github-actions bot added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. awaiting-review PR is awaiting review from an assigned reviewer labels Jan 27, 2026
gemini-code-assist[bot]
gemini-code-assist bot reviewed Jan 27, 2026
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request allows repository rules to define attributes that were previously reserved, specifically tags, deprecation, and visibility. The implementation correctly reduces the set of reserved attribute names to just name. The change is accompanied by new integration tests that verify a repository rule can now define and use a visibility attribute. The changes are clean, correct, and improve the flexibility of repository rule definitions. I have no specific comments as the implementation and tests look good.

@meteorcloudy meteorcloudy requested a review from Wyverald January 28, 2026 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Wyverald Wyverald Awaiting requested review from Wyverald

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting-review PR is awaiting review from an assigned reviewer team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[9.0.0] Can't define attributes for repository rules that should only be reserved for build rules

1 participant

@michaelm-openai