-
Notifications
You must be signed in to change notification settings - Fork 4.4k
PROTOTYPE/WIP: support CDC #28437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
tyler-french
wants to merge
1
commit into
bazelbuild:master
Choose a base branch
from
tyler-french:tfrench/chunked-remote-cache
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
PROTOTYPE/WIP: support CDC #28437
tyler-french
wants to merge
1
commit into
bazelbuild:master
from
tyler-french:tfrench/chunked-remote-cache
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8a45f14 to
dbc1af6
Compare
fmeum
reviewed
Jan 27, 2026
src/main/java/com/google/devtools/build/lib/remote/chunking/FastCDCChunker.java
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/remote/FastCDCChunker.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/remote/FastCDCChunker.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/remote/chunking/FastCDCChunker.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/remote/GrpcCacheClient.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/remote/ChunkedBlobUploader.java
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/remote/ChunkedBlobUploader.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/remote/merkletree/MerkleTreeComputer.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/remote/ChunkedBlobDownloader.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/remote/ChunkedBlobDownloader.java
Outdated
Show resolved
Hide resolved
fmeum
reviewed
Jan 27, 2026
src/main/java/com/google/devtools/build/lib/remote/ChunkedBlobUploader.java
Outdated
Show resolved
Hide resolved
789ab23 to
4349030
Compare
fmeum
reviewed
Jan 28, 2026
src/main/java/com/google/devtools/build/lib/remote/chunking/FastCDCChunker.java
Outdated
Show resolved
Hide resolved
438591d to
99dc964
Compare
99dc964 to
ca960ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR describes the implementation of CDC for Bazel, using FastCDC 2020 algorithm.
The key design consideration here are:
During a read:
SplitBlobto see if the remote has stored the blob with chunkingmap[blob] -> chunksDuring a write:
SplitSpliceBlobto register with the server that this blob digest can be constructed using these chunksOptimization: we don't need to store the individual chunks for uploads, since we have the whole files locally anyway. Storing their offset + len is sufficient to do all of the work.
Depends on a new version release of
remote_apisrepo.