bzlmod: add experimental_remote_downloader_bzlmod #28429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When this flag is enabled and a valid remote downloader was setup, Bazel will attempt to download bzlmod data through the remote downloader grpc endpoint. The canonical ID of the download will be the original url of the bzlmod data to help the remote downloader implement cache policy accordingly.
github-actions
bot
added
team-ExternalDeps
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces an experimental flag, --experimental_remote_downloader_bzlmod, to enable the use of a remote downloader for bzlmod registry file downloads. The changes correctly integrate this new option into the DownloadManager, allowing it to conditionally use a remote downloader or fall back to the existing HTTP downloader. Dedicated temporary directories are created for bzlmod downloads, and proper cleanup is attempted. The new functionality is well-covered by unit tests, ensuring that the remote downloader is used when enabled and the HTTP downloader is used otherwise. The code is clean and follows good practices for error handling and resource management.
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When this flag is enabled and a valid remote downloader was setup, Bazel
will attempt to download bzlmod data through the remote downloader grpc
endpoint.
The canonical ID of the download will be the original url of the bzlmod
data to help the remote downloader implement cache policy accordingly.