Fix VirtualActionInput pipe thread naming #28414
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team-Remote-Exec
Collaborator
Author
|
@bazel-io fork 9.1.0 |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly fixes the naming of virtual threads used for piping VirtualActionInput data, which will improve debuggability. While reviewing this change, I noticed a potential resource leak with the ExecutorService being used. It is a static field that is never shut down, which can be problematic in a long-running server. I've added a comment with details and a suggestion for refactoring.
src/main/java/com/google/devtools/build/lib/remote/RemoteExecutionCache.java
Show resolved
Hide resolved
coeuvre
approved these changes
Jan 26, 2026
coeuvre
added
awaiting-PR-merge
github-actions
bot
removed
the
awaiting-PR-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.