[9.1.0] Fix typo in SkyframeActionExecutor: Use lastEndTime instead of firstStartTime. #28396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tartTime. Fixes bazelbuild#28370 PiperOrigin-RevId: 859588739 Change-Id: I3d18c96146f30325c76d229a7f241acc0581f520
bazel-io
added
team-Core
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request corrects a typo in SkyframeActionExecutor.java. Previously, firstStartTime was erroneously used in place of lastEndTime when constructing an ActionExecutedEvent. This change ensures the correct end time is reported, improving the accuracy of build event data. The fix is correct and straightforward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28370
PiperOrigin-RevId: 859588739
Change-Id: I3d18c96146f30325c76d229a7f241acc0581f520
Commit d9e434a