Update default OpenBSD JDK to 21 #28150
Closed
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same reasons as 7cccf1c: * OpenJDK 21 is now the latest in the OpenBSD ports collection. * Plus 21 is now required for bootstrapping. As before, the FreeBSD macro is not touched, since that port patches it out anyway. Closes bazelbuild#28149
github-actions
bot
added
team-Rules-CPP
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the default JDK path for OpenBSD to version 21. The change correctly modifies the STANDARD_JAVABASE macro to point to /usr/local/jdk-21. According to the pull request description, this is necessary as OpenJDK 21 is now the standard in the OpenBSD ports collection and is required for bootstrapping. The change is minimal, targeted, and follows the existing design for platform-specific JDK paths. I find the change to be correct and have no further recommendations.
meisterT
approved these changes
Jan 7, 2026
meisterT
added
awaiting-PR-merge
github-actions
bot
removed
the
awaiting-PR-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same reasons as 7cccf1c:
As before, the FreeBSD macro is not touched, since that port patches it out anyway.
Closes #28149