[8.5.1] Enable --experimental_retain_test_configuration_across_testonly
#28116
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids action conflicts when `testonly` non-test targets depend on test targets. Until `--incompatible_check_testonly_for_output_files` is flipped, it is still possible to get action conflicts when a non-`testonly` target depends on an output file of a test. Since this can be fixed by adding the missing `testonly` annotation, this is only a minor concern. Fixes bazelbuild#28056 Closes bazelbuild#28073. PiperOrigin-RevId: 847892897 Change-Id: I60e908a22b51c307306760aa054b3968cfbebac2
bazel-io
added
team-Configurability
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request enables the experimental_retain_test_configuration_across_testonly flag by default to resolve action conflicts. The change is straightforward. My main feedback is to consider removing the EXPERIMENTAL tag from this option, as enabling it by default implies it has reached a stable state.
| @Option( | ||
| name = "experimental_retain_test_configuration_across_testonly", | ||
| defaultValue = "false", | ||
| defaultValue = "true", |
There was a problem hiding this comment.
Since this flag is now being enabled by default, it's worth considering removing the EXPERIMENTAL metadata tag associated with it (on line 192). Features enabled by default are generally expected to be stable, and keeping the experimental tag could be confusing for users.
gregestren
approved these changes
Jan 5, 2026
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids action conflicts when
testonlynon-test targets depend on test targets.Until
--incompatible_check_testonly_for_output_filesis flipped, it is still possible to get action conflicts when a non-testonlytarget depends on an output file of a test. Since this can be fixed by adding the missingtestonlyannotation, this is only a minor concern.Fixes #28056
Closes #28073.
PiperOrigin-RevId: 847892897
Change-Id: I60e908a22b51c307306760aa054b3968cfbebac2
Commit bcd8bcb