Skip to content

fix error message for experimental API flag #28094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alexeagle wants to merge 1 commit into from
Closed

fix error message for experimental API flag #28094

alexeagle wants to merge 1 commit into from

Conversation

@alexeagle
Copy link
Contributor

@alexeagle alexeagle commented Dec 24, 2025

experimental_allow_map_directory is the new name, this was renamed after landing in dcc3f29

@alexeagle
fix error message for experimental API flag
151deb7 
experimental_allow_map_directory is the new name, this was renamed after landing in dcc3f29
@alexeagle alexeagle requested a review from a team as a code owner December 24, 2025 01:08
@alexeagle alexeagle requested review from mai93 and removed request for a team December 24, 2025 01:08
@github-actions github-actions bot added team-Configurability platforms, toolchains, cquery, select(), config transitions awaiting-review PR is awaiting review from an assigned reviewer labels Dec 24, 2025
gemini-code-assist[bot]
gemini-code-assist bot reviewed Dec 24, 2025
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly updates an error message to refer to the renamed experimental flag --experimental_allow_map_directory. The change is straightforward and correct.

@fmeum
Copy link
Collaborator

fmeum commented Dec 24, 2025

@bazel-io fork 9.0.0

@bazel-io bazel-io mentioned this pull request Dec 24, 2025
Closed
@gregestren gregestren added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jan 5, 2026
@copybara-service copybara-service bot closed this in d563497 Jan 6, 2026
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Jan 6, 2026
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Jan 6, 2026
@alexeagle @bazel-io
fix error message for experimental API flag
ac3a815 
experimental_allow_map_directory is the new name, this was renamed after landing in dcc3f29

Closes bazelbuild#28094.

PiperOrigin-RevId: 852759958
Change-Id: I3a326daa2d8166fac92f234ac2618fa361bda276
@bazel-io bazel-io mentioned this pull request Jan 6, 2026
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jan 6, 2026
@bazel-io @alexeagle
[9.0.0] fix error message for experimental API flag (#28169)
de7ac64 
experimental_allow_map_directory is the new name, this was renamed after
landing in dcc3f29

Closes #28094.

PiperOrigin-RevId: 852759958
Change-Id: I3a326daa2d8166fac92f234ac2618fa361bda276

Commit
d563497

Co-authored-by: Alex Eagle <alex@aspect.build>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gregestren gregestren gregestren approved these changes

@mai93 mai93 Awaiting requested review from mai93 mai93 is a code owner automatically assigned from bazelbuild/configurability

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

team-Configurability platforms, toolchains, cquery, select(), config transitions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexeagle @fmeum @gregestren